Skip to content

Add EER support in Dose Analysis #852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
ratolon wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

Add EER support in Dose Analysis #852

ratolon wants to merge 7 commits into from

Conversation

@ratolon
Copy link
Contributor

@ratolon ratolon commented Dec 11, 2024

Xmipp3 Dose Analysis fails when using EER. This is against our latest effort for EER support in Xmipp. Thus, I am implementing EER support for dose analysis protocol.

Bsos,
Mikel.

@ratolon ratolon added the bug Something isn't working label Dec 11, 2024
@ratolon ratolon self-assigned this Dec 11, 2024
@albertmena
Copy link
Collaborator

albertmena commented Dec 11, 2024

Related: I2PC/xmipp3#939

@ratolon ratolon marked this pull request as ready for review December 11, 2024 15:11
@ratolon ratolon marked this pull request as draft December 11, 2024 15:33
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 11, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@ratolon
Copy link
Contributor Author

ratolon commented Dec 11, 2024

Okay seems to be working but it is still very slow. The slowness will be addressed for next release

@ratolon ratolon marked this pull request as ready for review December 11, 2024 16:27
albertmena
albertmena requested changes Dec 12, 2024
View reviewed changes
Copy link
Collaborator

@albertmena albertmena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The protocol never ends (2h) with EER files, running 8 files from https://www.ebi.ac.uk/empiar/EMPIAR-11487/

albertmena
albertmena reviewed Dec 12, 2024
View reviewed changes
Copy link
Collaborator

@albertmena albertmena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The protocol never ends (2h) with EER files, running 8 files from https://www.ebi.ac.uk/empiar/EMPIAR-11487/

@albertmena albertmena self-requested a review December 12, 2024 08:41
@ratolon
Copy link
Contributor Author

ratolon commented Dec 12, 2024

This protocol clearly needs more work so let's keep it a draft

@ratolon ratolon marked this pull request as draft December 12, 2024 08:49
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 26, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@oierlauzi
Copy link
Collaborator

oierlauzi commented Jun 26, 2025

The protocol never ends (2h) with EER files, running 8 files from https://www.ebi.ac.uk/empiar/EMPIAR-11487/

The protocol never ends (2h) with EER files, running 8 files from https://www.ebi.ac.uk/empiar/EMPIAR-11487/

I think that's a separate issue regarding the streaming implementation. I'll have a look

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oierlauzi oierlauzi Awaiting requested review from oierlauzi

@albertmena albertmena Awaiting requested review from albertmena

Requested changes must be addressed to merge this pull request.

Assignees

@ratolon ratolon

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ratolon @albertmena @oierlauzi