Fix shift particles protocol #978
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e volume so that it appears with the expected displacement
DavidHerreros
changed the title
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The shift particles protocol was producing unexpected results, as the volumes reconstructed from it were not appearing in the displaced position selected from the form/wizard.
These new changes force the transformation matrices assigned to the particles to shift the reconstruction volume correctly. The new matrices consider both the case of modifying only the transformation matrices and the case of applying the shift to the particles.
NOTE: When applying the shift to the images, only X and Y shifts will be applied. Shifts associated with the Z axis will be stored in the rotation matrix.