Fix private operator time drift #2300
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…BTechLab/uid2-operator into ccm-UID2-6489-add-sync-fix-time-drift
…ator into ccm-UID2-6489-drift
…ator into ccm-UID2-6489-drift
…ator into ccm-UID2-6489-drift
| fi | ||
| } | ||
|
|
||
| start_time_sync_loop() { |
Contributor
There was a problem hiding this comment.
I feel this is a bit complex.
Why not something much simpler like
sync_enclave_time() {
curl -s -f -x socks5h://127.0.0.1:3305 "${TIME_SYNC_URL}" | xargs -I{} date -u -s "{}"
}
Trust the parent instance clock without the condition ?
|
|
||
| start_time_sync_loop() { | ||
| while true; do | ||
| sleep "${TIME_SYNC_INTERVAL_SECONDS}" |
Contributor
There was a problem hiding this comment.
suggest using cron. Python sleep is process based, if process crashes (this process running, isn't a requirement for our enclave), it stops.
Using cron on systemd timer would be better IMO
| name: nmap-ncat | ||
| state: latest | ||
|
|
||
| - name: Install chrony for time sync |
Contributor
There was a problem hiding this comment.
I am not sure if we need this. This AMI is the parent instance which already has time sync configured with AWS time server
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correct the time drift once a day
Test: