Add #type: ignore to silence mypy errors #58
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #58 +/- ##
==========================================
+ Coverage 95.74% 96.01% +0.27%
==========================================
Files 5 5
Lines 188 201 +13
==========================================
+ Hits 180 193 +13
Misses 8 8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- Configure pre-commit/mypy to - Always type check all files. - Ignore missing hints from globalwarmingpotentials. - Warn on unused ignores. - Use pint's Scalar type directly instead of redefining it. - Remove unused ignores.
- Allow as direct argument to configure_currency(); validate str values against the enumeration. - Remove Literal type and "type: ignore" required to accommodate it. - Expand tests.
khaeru
left a comment
khaeru
left a comment
There was a problem hiding this comment.
Sorry for the delay in reviewing here.
Inspired by iiasa/ixmp#581, I'd prefer to go the route of addressing the things that necessitate # type: ignore comments, rather than ignoring them. I've pushed a couple of commits to the branch that hopefully achieve that.
For a few of the added ignores on the branch, I couldn't reproduce a mypy error or warning on my system using pre-commit, plain mypy, or the language server in my editor. If they still give issues on your system, perhaps we can discuss 1:1 about how to adjust config.
|
Sounds good, no worries, I'll update my fork of the repo and see if the errors disappear |
3 participants
This PR silences the errors that mypy has been throwing recently (https://github.com/IAMconsortium/units/actions/runs/19125791339).