Fixed shebang and shellcheck issues #722
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: schamola <[email protected]>
vivekpandeyibm
approved these changes
Dec 16, 2025
nitismis
reviewed
Dec 16, 2025
| /usr/bin/tar -xvf dnf_bundle_aix_71_72.tar | ||
| fi | ||
|
|
||
| # shellcheck disable=SC2154 |
Member
There was a problem hiding this comment.
Don't ignore this (remove this ignore)
Instead change line 202 from: ./install_dnf.sh "$arg" "$yum4" "$yum3_instd" 2
to this:
./install_dnf.sh "$mnt_path" "$yum4" "$yum3_instd" 2
at line 59 it is already: mnt_path=$1
nitismis
reviewed
Dec 16, 2025
| @@ -1,4 +1,3 @@ | |||
| #!/usr/bin/python | |||
Member
There was a problem hiding this comment.
better put it as:
#!/usr/bin/env python
as mentioned here: https://docs.ansible.com/ansible-core/2.16/dev_guide/testing/sanity/shellcheck.html
Signed-off-by: schamola <[email protected]>
nitismis
approved these changes
Dec 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.