Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: New ConfigurationId to group together a configuration identifier #54

Merged
merged 6 commits into from
Jan 17, 2025

Conversation

jgsogo
Copy link
Collaborator

@jgsogo jgsogo commented Jan 16, 2025

closes #11

  • New public ConfigurationId type to group together a configuration identifier
  • New AppConfigurationHttp client that can be instantiated with a custom server address (not public API)
  • Convert existing IBMCloud implement in a wrapper on top of that generic client

jgsogo and others added 6 commits January 16, 2025 12:39
- We provide a new AppConfigurationClient that can be instantiated with a custom
server address (not yet offered as a feature to clients)
- We convert existing IBMCloud implement in a wrapper on top of that generic client
- We implement some new e2e tests that actually exercise the business logic
associated with the server

Co-authored-by: Rainer Schoenberger <[email protected]>
Signed-off-by: Javier G. Sogo <[email protected]>
Co-authored-by: Rainer Schoenberger <[email protected]>
Signed-off-by: Javier G. Sogo <[email protected]>
Co-authored-by: Rainer Schoenberger <[email protected]>
Signed-off-by: Javier G. Sogo <[email protected]>
Co-authored-by: Rainer Schoenberger <[email protected]>
Signed-off-by: Javier G. Sogo <[email protected]>
Co-authored-by: Rainer Schoenberger <[email protected]>
Signed-off-by: Javier G. Sogo <[email protected]>
@rainerschoe rainerschoe marked this pull request as ready for review January 17, 2025 10:34
@jgsogo jgsogo changed the title test: Add e2e testing using a local server feat: New ConfigurationId to group together a configuration identifier Jan 17, 2025
Comment on lines +124 to +128
// TODO: Identify if token expired, get new one and retry
if false {
let access_token = self.token_provider.get_access_token()?;
self.access_token.replace(access_token);
}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope the compiler will optimize this always-false block.

@jgsogo jgsogo enabled auto-merge (squash) January 17, 2025 10:49
@jgsogo jgsogo merged commit bfd911c into IBM:main Jan 17, 2025
2 checks passed
@jgsogo jgsogo deleted the test/e2e branch January 17, 2025 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write more integration/E2E tests
2 participants