feat: New ConfigurationId to group together a configuration identifier
#54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- We provide a new AppConfigurationClient that can be instantiated with a custom server address (not yet offered as a feature to clients) - We convert existing IBMCloud implement in a wrapper on top of that generic client - We implement some new e2e tests that actually exercise the business logic associated with the server Co-authored-by: Rainer Schoenberger <[email protected]> Signed-off-by: Javier G. Sogo <[email protected]>
Co-authored-by: Rainer Schoenberger <[email protected]> Signed-off-by: Javier G. Sogo <[email protected]>
Co-authored-by: Rainer Schoenberger <[email protected]> Signed-off-by: Javier G. Sogo <[email protected]>
Co-authored-by: Rainer Schoenberger <[email protected]> Signed-off-by: Javier G. Sogo <[email protected]>
Signed-off-by: Javier G. Sogo <[email protected]>
Co-authored-by: Rainer Schoenberger <[email protected]> Signed-off-by: Javier G. Sogo <[email protected]>
jgsogo
changed the title
ConfigurationId to group together a configuration identifier
jgsogo
commented
Jan 17, 2025
Comment on lines
+124
to
+128
| // TODO: Identify if token expired, get new one and retry | ||
| if false { | ||
| let access_token = self.token_provider.get_access_token()?; | ||
| self.access_token.replace(access_token); | ||
| } |
There was a problem hiding this comment.
I hope the compiler will optimize this always-false block.
rainerschoe
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #11
ConfigurationIdtype to group together a configuration identifierAppConfigurationHttpclient that can be instantiated with a custom server address (not public API)