refact: Isolate FeatureSnapshot and PropertySnapshot from crate::models types
#56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Javier G. Sogo <[email protected]>
jgsogo
commented
Jan 20, 2025
| } | ||
|
|
||
| impl FeatureSnapshot { | ||
| pub(crate) fn new( | ||
| feature: crate::models::Feature, | ||
| segments: HashMap<String, crate::models::Segment>, | ||
| ) -> Self { | ||
| Self { feature, segments } | ||
| let segment_rules = SegmentRules::new(segments, feature.segment_rules, feature.kind); |
There was a problem hiding this comment.
Probable in a following PR the new method should just take the members and really remove all the references to crate::models from here.
Draft
rainerschoe
approved these changes
Feb 4, 2025
Merged
jgsogo
added a commit
that referenced
this pull request
Feb 12, 2025
Following #56, this PR moves the `FeatureSnapshot` and `PropertySnapshot` inside `Configuration` (closer to JSON data), this way the json-models doesn't leak into the application. --------- Signed-off-by: Javier G. Sogo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A refactor going in the direction of isolating our logic from the JSON data returned by the server:
crate::models::...members fromFeatureSnapshotandPropertySnapshotTargetingRules andSegments intoSegmentRulesobject. This new type handles the logic related tofind_applicable_segment_rule_for_entityand also the one to get theValuefrom the foundTargetingRule(now hidden into aSegmentRule)