Skip to content

feat: example app#58

Merged
dabrad26 merged 9 commits intomainfrom
example
Apr 11, 2025
Merged

feat: example app#58
dabrad26 merged 9 commits intomainfrom
example

Conversation

@dabrad26
Copy link
Copy Markdown
Contributor

@dabrad26 dabrad26 commented Apr 9, 2025

Closes #56

npm run dev

@dabrad26 dabrad26 requested a review from dwosk April 9, 2025 23:37
@dabrad26 dabrad26 requested a review from bitngu April 11, 2025 07:46
@dabrad26
Copy link
Copy Markdown
Contributor Author

This is ready for review.

you can check it out and run npm run start:example (after npm ci)

Tried to avoid duplicating code for examples verse real stuff.

Angular, React code examples are just strings and not rendered. But the JavaScript version is rende

@ycliu0953 I could not assign you since you are not a member of the IBM org it seems.

@dabrad26
Copy link
Copy Markdown
Contributor Author

@dwosk I was thinking we could remove the index.html page and web pack stuff for running it. And instead use this. And expand it as needed to meet the needs of developers.

If possible we can build this example app and then build the docs and toss the docs into an asset folder in the build and I can add a link to it from the app. So Github Pages has the main app and the docs app in the same path and we just include a link or render.

In theory then customers can use it right from GH pages and not need to run it locally (maybe we expand the README to indicate how to install the library and stuff more).

Copy link
Copy Markdown
Member

@dwosk dwosk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I agree on deploying to GitHub Pages. Then we can remove the older one.

@dabrad26
Copy link
Copy Markdown
Contributor Author

Yeah I agree on deploying to GitHub Pages. Then we can remove the older one.

Just pushed a commit to do this build setup.

@dabrad26 dabrad26 merged commit a29728f into main Apr 11, 2025
3 of 4 checks passed
@dabrad26 dabrad26 deleted the example branch April 11, 2025 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add code examples

2 participants