feat: #641 - first draft implementation, python only #642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Juan Cappi <[email protected]>
juancappi
force-pushed
the
feat/641-fixed-size-token-chunking
branch
from
43d36f1
to
242fad1
Compare
|
@touma-I would you please take a look to confirm I'm in the right track? |
to better reflect the new chunker is also leveraging a Llama Index chunker Signed-off-by: Juan Cappi <[email protected]> IBM#641
Signed-off-by: Juan Cappi <[email protected]>
|
@dolfim-ibm this is ready for review |
Signed-off-by: Juan Cappi <[email protected]>
Signed-off-by: Juan Cappi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Partially implements #641
This is a draft for pure python only. Ray is still pending