Fix errors in train.py & modelling.py; add ability to track multiple metrics at once #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e metrics at once Signed-off-by: ShreyBiswas <[email protected]>
Signed-off-by: ShreyBiswas <[email protected]>
Forward may get called with different arguments depending on the model; extra arguments like token_type_ids could cause it to crash. This is a simpler way to ignore those. Signed-off-by: ShreyBiswas <[email protected]>
Signed-off-by: ShreyBiswas <[email protected]>
|
Thanks @ShreyBiswas! can you add |
Signed-off-by: Shrey Biswas <[email protected]>
|
Should be added now 👍 |
elronbandel
approved these changes
Oct 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Came across a few errors while testing that I've fixed in each commit.