Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ILS-247 adjust to envsubst usage #2312

Open
wants to merge 2 commits into
base: scripts-dev
Choose a base branch
from
Open

ILS-247 adjust to envsubst usage #2312

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
18f34a7
ILS-247 adjust to envsubst usage
karol-wozniak-ibm Nov 21, 2024
c49d6a9
REVIEW: Unnecessary comment removed
karol-wozniak-ibm Nov 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...cy/egress/license-service-reporter-manually/ibm-license-service-reporter-oidc-egress.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,6 @@ spec:
egress:
- to:
- ipBlock:
cidr: <CIDR of oidc-issuer-url> # Replace with actual CIDR range
cidr: ${OIDC-CIDF}
policyTypes:
- Egress
8 changes: 4 additions & 4 deletions ...ense-service-reporter-manually/ibm-license-service-reporter-operator-k8s-cncf-egress.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,11 @@ spec:
matchLabels:
name: ibm-license-service-reporter-operator
egress:
- ports:
- protocol: TCP
port: <$TargetPort> # TargetPort from the DEFAULT KUBERNETES SERVICE
- ports:S
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,
May I ask that do we expect this S in line 16?

- protocol: TCP
port: ${K8-API-SERVER-PORT} # TargetPort from the DEFAULT KUBERNETES SERVICE
to:
- ipBlock:
cidr: <IPs>/32 # IPs from the DEFAULT KUBERNETES SERVICE
cidr: ${K8-API-SERVER-CIRD} # IP from the DEFAULT KUBERNETES SERVICE
policyTypes:
- Egress