-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keycloak 26 enable internal connection #2386
base: master
Are you sure you want to change the base?
Conversation
Welcome @rickysway! It looks like this is your first PR to IBM/ibm-common-service-operator 🎉 |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: rickysway The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @rickysway. Thanks for your PR. I'm waiting for a IBM member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@@ -964,7 +964,7 @@ spec: | |||
apiVersion: route.openshift.io/v1 | |||
kind: Route | |||
name: keycloak | |||
path: .spec.host | |||
path: https://+.spec.host |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does not work on Keycloak 22/24. Noting the url becomes https://https//........
This works on Keycloak 26 however
Hello @rickysway, I think we could directly define
When it is enabled as |
What this PR does / why we need it:
As of Keycloak 25 onwards, with the move to Hostname V2, for internal cluster Pod to Service communication you need to enable
backchannelDynamic
(effectively adding env varKC_HOSTNAME_BACKCHANNEL_DYNAMIC: 'true'
to Keycloak), we opt for setting theenv
as a customer could potentially installed Keycloak 24 in another namespace after this installation, which will break their Keycloak 26 installation if we relied onbackchannelDynamic
due to the change of CRDhttps://www.keycloak.org/server/hostname#_utilizing_an_internal_url_for_communication_among_clients
According to Keycloak Hostname V2 docs when
spec.hostname.backchannelDynamic: true
the hostname needs to be a URL and not just hostname, so addinghttps://
to the start of the hostname valuehttps://www.keycloak.org/server/hostname#_validations
Which issue(s) this PR fixes:
Fixes https://github.ibm.com/IBMPrivateCloud/roadmap/issues/65922
Special notes for your reviewer:
Unsure if the below section "backport" is needed
How to backport this PR to other branch:
backport <branch-name>
backport <branch-name>
and leave a comment/backport
to trigger the backport action