-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add manage-cert-rotation: yes
label to cs-ca-certificate CR
#2467
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Allen Li <[email protected]>
Signed-off-by: Allen Li <[email protected]>
Signed-off-by: Allen Li <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qpdpQ The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Allen Li <[email protected]>
test logs:
|
@@ -468,6 +468,27 @@ func (b *Bootstrap) CreateOrUpdateFromYaml(yamlContent []byte, alwaysUpdate ...b | |||
obj.Object["spec"].(map[string]interface{})["config"] = sub.Object["spec"].(map[string]interface{})["config"] | |||
} | |||
update = !equality.Semantic.DeepEqual(sub.Object["spec"], obj.Object["spec"]) | |||
} else if gvk.Kind == "Certificate" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @qpdpQ
I am thinking that CS operator will never "update" a certificate resource given this resource does not have .metadata.annotations.version
defined.
Can you have a test on CS operator without above particular Certificate Kind handling logic, and see if CS operator will update the certificate? Thank you!
Signed-off-by: Allen Li <[email protected]>
Signed-off-by: Allen Li <[email protected]>
add a new field |
Signed-off-by: Allen Li <[email protected]>
What this PR does / why we need it:
add
manage-cert-rotation: yes
label to cs-ca-certificate CRupdate operator code to ignore reconciling
renewBefore
fieldWhich issue(s) this PR fixes:
Fixes # https://github.ibm.com/IBMPrivateCloud/roadmap/issues/66198
Special notes for your reviewer:
How the test is done?
we could use this image to test
quay.io/yuchen_li1/common-service-operator-amd64:dev
How to backport this PR to other branch:
backport <branch-name>
backport <branch-name>
and leave a comment/backport
to trigger the backport action