Skip to content

Add GRPC Support to Mount and UnMount s3fs and rclone both #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 61 commits into
base: main
Choose a base branch
from

Conversation

ashimagarg27
Copy link
Member

Describe your changes

Issue ticket number and link

Checklist before requesting a review

  • I have performed a self-review of my code
  • If it is a core feature, I have added thorough tests.
  • I have made sure existing UTs are not impacted
  • I have executed all necessary linter and made sure internal pipeline/travis is not broken

Signed-off-by: Ashima-Ashima1 <[email protected]>
Signed-off-by: Ashima-Ashima1 <[email protected]>
Signed-off-by: Ashima-Ashima1 <[email protected]>
Signed-off-by: Ashima-Ashima1 <[email protected]>
Signed-off-by: Ashima-Ashima1 <[email protected]>
Signed-off-by: Ashima-Ashima1 <[email protected]>
Signed-off-by: Ashima-Ashima1 <[email protected]>
Signed-off-by: Ashima-Ashima1 <[email protected]>
Signed-off-by: Ashima-Ashima1 <[email protected]>
Signed-off-by: Ashima-Ashima1 <[email protected]>
Signed-off-by: Ashima-Ashima1 <[email protected]>
Signed-off-by: Ashima-Ashima1 <[email protected]>
Signed-off-by: Ashima-Ashima1 <[email protected]>
Signed-off-by: Ashima-Ashima1 <[email protected]>
Signed-off-by: Ashima-Ashima1 <[email protected]>
Signed-off-by: Ashima-Ashima1 <[email protected]>
Signed-off-by: Ashima-Ashima1 <[email protected]>
Signed-off-by: Ashima-Ashima1 <[email protected]>
Signed-off-by: Ashima-Ashima1 <[email protected]>
Signed-off-by: Ashima-Ashima1 <[email protected]>
Signed-off-by: Ashima-Ashima1 <[email protected]>
Signed-off-by: Ashima-Ashima1 <[email protected]>
Signed-off-by: Ashima-Ashima1 <[email protected]>
Signed-off-by: Ashima-Ashima1 <[email protected]>
Signed-off-by: Ashima-Ashima1 <[email protected]>
Signed-off-by: Ashima-Ashima1 <[email protected]>
Signed-off-by: Ashima-Ashima1 <[email protected]>
ashimagarg27 and others added 25 commits May 7, 2025 18:38
Signed-off-by: Ashima-Ashima1 <[email protected]>
Signed-off-by: Ashima-Ashima1 <[email protected]>
map http codes to grpc codes
s3fs: remove password file after unmounting
Signed-off-by: Ashima-Ashima1 <[email protected]>
Signed-off-by: Ashima-Ashima1 <[email protected]>
Signed-off-by: Ashima-Ashima1 <[email protected]>
* Update mounter_utils.go

* revert changes
Signed-off-by: Ashima-Ashima1 <[email protected]>
* Update COS CSI config path & socket path

Signed-off-by: Mayank Sachan <[email protected]>

* Fix log message order

Signed-off-by: Mayank Sachan <[email protected]>

---------

Signed-off-by: Mayank Sachan <[email protected]>
Copy link
Member

@mssachan mssachan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall changes looks good. Added minor comments.
PTAL

@@ -103,6 +106,14 @@ func NewS3fsMounter(secretMap map[string]string, mountOptions []string, mounterU
func (s3fs *S3fsMounter) Mount(source string, target string) error {
klog.Info("-S3FSMounter Mount-")
klog.Infof("Mount args:\n\tsource: <%s>\n\ttarget: <%s>", source, target)

var metaRoot string
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets give relevant variable name for s3fsCred Directory.

@@ -173,9 +173,9 @@ func createCOSCSIMounterRequest(payload string, url string) (string, error) {
}

responseBody := string(body)
klog.Infof("response from cos-csi-mounter -> Exit Status Code: %s ,ResponseCode: %v", responseBody, response.StatusCode)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

klog.Infof("response from cos-csi-mounter -> Response body: %s, Response code: %v", responseBody, response.StatusCode)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants