-
Notifications
You must be signed in to change notification settings - Fork 11
Add GRPC Support to Mount and UnMount s3fs and rclone both #154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Ashima-Ashima1 <[email protected]>
Signed-off-by: Ashima-Ashima1 <[email protected]>
Signed-off-by: Ashima-Ashima1 <[email protected]>
Signed-off-by: Ashima-Ashima1 <[email protected]>
Signed-off-by: Ashima-Ashima1 <[email protected]>
Signed-off-by: Ashima-Ashima1 <[email protected]>
Signed-off-by: Ashima-Ashima1 <[email protected]>
Signed-off-by: Ashima-Ashima1 <[email protected]>
Signed-off-by: Ashima-Ashima1 <[email protected]>
Signed-off-by: Ashima-Ashima1 <[email protected]>
Signed-off-by: Ashima-Ashima1 <[email protected]>
Signed-off-by: Ashima-Ashima1 <[email protected]>
Signed-off-by: Ashima-Ashima1 <[email protected]>
Signed-off-by: Ashima-Ashima1 <[email protected]>
Signed-off-by: Ashima-Ashima1 <[email protected]>
Signed-off-by: Ashima-Ashima1 <[email protected]>
Signed-off-by: Ashima-Ashima1 <[email protected]>
Signed-off-by: Ashima-Ashima1 <[email protected]>
Signed-off-by: Ashima-Ashima1 <[email protected]>
Signed-off-by: Ashima-Ashima1 <[email protected]>
Signed-off-by: Ashima-Ashima1 <[email protected]>
Signed-off-by: Ashima-Ashima1 <[email protected]>
Signed-off-by: Ashima-Ashima1 <[email protected]>
Signed-off-by: Ashima-Ashima1 <[email protected]>
Signed-off-by: Ashima-Ashima1 <[email protected]>
Signed-off-by: Ashima-Ashima1 <[email protected]>
Signed-off-by: Ashima-Ashima1 <[email protected]>
Signed-off-by: Ashima-Ashima1 <[email protected]>
Signed-off-by: Ashima-Ashima1 <[email protected]>
Signed-off-by: Ashima-Ashima1 <[email protected]>
Signed-off-by: Ashima-Ashima1 <[email protected]>
Signed-off-by: Ashima-Ashima1 <[email protected]>
map http codes to grpc codes
Signed-off-by: Ashima-Ashima1 <[email protected]>
Signed-off-by: Ashima-Ashima1 <[email protected]>
Signed-off-by: Ashima-Ashima1 <[email protected]>
Signed-off-by: Ashima-Ashima1 <[email protected]>
Signed-off-by: Ashima-Ashima1 <[email protected]>
Signed-off-by: Ashima-Ashima1 <[email protected]>
Signed-off-by: Ashima-Ashima1 <[email protected]>
s3fs: remove password file after unmounting
Signed-off-by: Ashima-Ashima1 <[email protected]>
Signed-off-by: Ashima-Ashima1 <[email protected]>
Signed-off-by: Ashima-Ashima1 <[email protected]>
Signed-off-by: Ashima-Ashima1 <[email protected]>
* Update mounter_utils.go * revert changes
Signed-off-by: Ashima-Ashima1 <[email protected]>
* Update COS CSI config path & socket path Signed-off-by: Mayank Sachan <[email protected]> * Fix log message order Signed-off-by: Mayank Sachan <[email protected]> --------- Signed-off-by: Mayank Sachan <[email protected]>
Signed-off-by: Ashima-Ashima1 <[email protected]>
Signed-off-by: Ashima-Ashima1 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall changes looks good. Added minor comments.
PTAL
@@ -103,6 +106,14 @@ func NewS3fsMounter(secretMap map[string]string, mountOptions []string, mounterU | |||
func (s3fs *S3fsMounter) Mount(source string, target string) error { | |||
klog.Info("-S3FSMounter Mount-") | |||
klog.Infof("Mount args:\n\tsource: <%s>\n\ttarget: <%s>", source, target) | |||
|
|||
var metaRoot string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets give relevant variable name for s3fsCred Directory.
Signed-off-by: Ashima-Ashima1 <[email protected]>
Signed-off-by: Ashima-Ashima1 <[email protected]>
@@ -173,9 +173,9 @@ func createCOSCSIMounterRequest(payload string, url string) (string, error) { | |||
} | |||
|
|||
responseBody := string(body) | |||
klog.Infof("response from cos-csi-mounter -> Exit Status Code: %s ,ResponseCode: %v", responseBody, response.StatusCode) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
klog.Infof("response from cos-csi-mounter -> Response body: %s, Response code: %v", responseBody, response.StatusCode)
Describe your changes
Issue ticket number and link
Checklist before requesting a review