Skip to content

Add GRPC Support to Mount and UnMount s3fs and rclone both #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 61 commits into
base: main
Choose a base branch
from
Open

Add GRPC Support to Mount and UnMount s3fs and rclone both #154

wants to merge 61 commits into from

Conversation

ashimagarg27
Copy link
Member

Describe your changes

Issue ticket number and link

Checklist before requesting a review

  • I have performed a self-review of my code
  • If it is a core feature, I have added thorough tests.
  • I have made sure existing UTs are not impacted
  • I have executed all necessary linter and made sure internal pipeline/travis is not broken

@ashimagarg27
update go.mod
373a098 
Signed-off-by: Ashima-Ashima1 <[email protected]>
@ashimagarg27
cos apis
ee7638b 
Signed-off-by: Ashima-Ashima1 <[email protected]>
@ashimagarg27
cos apis
217aa92 
Signed-off-by: Ashima-Ashima1 <[email protected]>
@ashimagarg27
unmounting...
8b356b0 
Signed-off-by: Ashima-Ashima1 <[email protected]>
@ashimagarg27
comments uts
332a995 
Signed-off-by: Ashima-Ashima1 <[email protected]>
@ashimagarg27
cos apis
26af783 
Signed-off-by: Ashima-Ashima1 <[email protected]>
@ashimagarg27
cos apis
fdaed43 
Signed-off-by: Ashima-Ashima1 <[email protected]>
@ashimagarg27
Merge branch 'main' into grpc-01
88f3d1d
@ashimagarg27
fix travis
89c4f44 
Signed-off-by: Ashima-Ashima1 <[email protected]>
@ashimagarg27
cos apis
1ff180f 
Signed-off-by: Ashima-Ashima1 <[email protected]>
@ashimagarg27
cos apis
6edc289 
Signed-off-by: Ashima-Ashima1 <[email protected]>
@ashimagarg27
cos apis
eef5704 
Signed-off-by: Ashima-Ashima1 <[email protected]>
@ashimagarg27
cos apis
c4fd5d0 
Signed-off-by: Ashima-Ashima1 <[email protected]>
@ashimagarg27
cos apis
aea5145 
Signed-off-by: Ashima-Ashima1 <[email protected]>
@ashimagarg27
cos apis
97b8625 
Signed-off-by: Ashima-Ashima1 <[email protected]>
@ashimagarg27
rebase branch and resolve conflicts
e71c592 
Signed-off-by: Ashima-Ashima1 <[email protected]>
@ashimagarg27
cos apis
2bf8745 
Signed-off-by: Ashima-Ashima1 <[email protected]>
@ashimagarg27
cos apis
0fe4a38 
Signed-off-by: Ashima-Ashima1 <[email protected]>
@ashimagarg27
cos apis
58213fa 
Signed-off-by: Ashima-Ashima1 <[email protected]>
@ashimagarg27
cos apis
5660a2d 
Signed-off-by: Ashima-Ashima1 <[email protected]>
@ashimagarg27
comment uts
a5fee80 
Signed-off-by: Ashima-Ashima1 <[email protected]>
@ashimagarg27
comment unused code
263daa0 
Signed-off-by: Ashima-Ashima1 <[email protected]>
@ashimagarg27
rebase branch and resolve conflicts
6680d77 
Signed-off-by: Ashima-Ashima1 <[email protected]>
@ashimagarg27
comment unused code
78d1194 
Signed-off-by: Ashima-Ashima1 <[email protected]>
@ashimagarg27
fix backoff
210dce2 
Signed-off-by: Ashima-Ashima1 <[email protected]>
@ashimagarg27
fix backoff
41d7150 
Signed-off-by: Ashima-Ashima1 <[email protected]>
@ashimagarg27
cos apis
3397d3f 
Signed-off-by: Ashima-Ashima1 <[email protected]>
@ashimagarg27
fix unmounting...
23c5c6c 
Signed-off-by: Ashima-Ashima1 <[email protected]>
@ashimagarg27
fix travis
1c02d4b 
Signed-off-by: Ashima-Ashima1 <[email protected]>
@ashimagarg27
fix travis
2b6c3d7 
Signed-off-by: Ashima-Ashima1 <[email protected]>
ashimagarg27 and others added 25 commits May 7, 2025 18:38
@ashimagarg27
resolve merge conflicts and rebase branch
f6137ce 
Signed-off-by: Ashima-Ashima1 <[email protected]>
@ashimagarg27
update go.mod and go version
0457fc5 
Signed-off-by: Ashima-Ashima1 <[email protected]>
@ashimagarg27
map http codes to grpc
229e54b 
Signed-off-by: Ashima-Ashima1 <[email protected]>
@Bhagyashreek8
Merge pull request #174 from IBM/add-latency
3e62a3b 
map http codes to grpc codes
@ashimagarg27
remove password file after unmounting
fb886bb 
Signed-off-by: Ashima-Ashima1 <[email protected]>
@ashimagarg27
remove password file after unmounting
e5260ce 
Signed-off-by: Ashima-Ashima1 <[email protected]>
@ashimagarg27
remove password file after unmounting
c6e7f7d 
Signed-off-by: Ashima-Ashima1 <[email protected]>
@ashimagarg27
remove password file after unmounting
b560fbc 
Signed-off-by: Ashima-Ashima1 <[email protected]>
@ashimagarg27
remove password file after unmounting
aee92e7 
Signed-off-by: Ashima-Ashima1 <[email protected]>
@ashimagarg27
remove password file after unmounting
1c5a135 
Signed-off-by: Ashima-Ashima1 <[email protected]>
@ashimagarg27
remove password file after unmounting
e1a19a0 
Signed-off-by: Ashima-Ashima1 <[email protected]>
@ashimagarg27
Merge pull request #175 from IBM/cleanup
e319f21 
s3fs: remove password file after unmounting
@ashimagarg27
resolve merge conflicts and rebase branch
62f3c8d 
Signed-off-by: Ashima-Ashima1 <[email protected]>
@ashimagarg27
update go.mod
f900a56 
Signed-off-by: Ashima-Ashima1 <[email protected]>
@ashimagarg27
add isGRPCServerAvailable check
5bc1c12 
Signed-off-by: Ashima-Ashima1 <[email protected]>
@ashimagarg27
fix travis
25482f7 
Signed-off-by: Ashima-Ashima1 <[email protected]>
@ashimagarg27
Merge branch 'main' into grpc-01
ccad2be
@mssachan
Fix for mount getting stuck forever (#177)
2f509da 
* Update mounter_utils.go

* revert changes
@ashimagarg27
cos apis
9942cd6 
Signed-off-by: Ashima-Ashima1 <[email protected]>
@ashimagarg27
Merge branch 'main' into grpc-01
121051f
@Bhagyashreek8
remove unnecessary leading newline to fix linter
e6182ec
@mssachan
Update COS CSI config path & socket path (#183)
72a1fd9 
* Update COS CSI config path & socket path

Signed-off-by: Mayank Sachan <[email protected]>

* Fix log message order

Signed-off-by: Mayank Sachan <[email protected]>

---------

Signed-off-by: Mayank Sachan <[email protected]>
@ashimagarg27
resolve merge conflicts and rebase branch
fc07742 
Signed-off-by: Ashima-Ashima1 <[email protected]>
@Bhagyashreek8
run livenessProbe container as non-root user (#185)
2f09b33
@ashimagarg27
resolve merge conflicts and rebase branch
912ad73 
Signed-off-by: Ashima-Ashima1 <[email protected]>
mssachan
mssachan requested changes Jun 6, 2025
View reviewed changes
Copy link
Member

@mssachan mssachan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall changes looks good. Added minor comments.
PTAL

pkg/mounter/mounter-s3fs.go
@@ -103,6 +106,14 @@ func NewS3fsMounter(secretMap map[string]string, mountOptions []string, mounterU
func (s3fs *S3fsMounter) Mount(source string, target string) error {
klog.Info("-S3FSMounter Mount-")
klog.Infof("Mount args:\n\tsource: <%s>\n\ttarget: <%s>", source, target)

var metaRoot string
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets give relevant variable name for s3fsCred Directory.

mssachan
mssachan reviewed Jun 6, 2025
View reviewed changes
pkg/mounter/mounter.go
@@ -173,9 +173,9 @@ func createCOSCSIMounterRequest(payload string, url string) (string, error) {
}

responseBody := string(body)
klog.Infof("response from cos-csi-mounter -> Exit Status Code: %s ,ResponseCode: %v", responseBody, response.StatusCode)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

klog.Infof("response from cos-csi-mounter -> Response body: %s, Response code: %v", responseBody, response.StatusCode)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mssachan mssachan mssachan requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ashimagarg27 @mssachan @Bhagyashreek8