s3fs: remove password file after unmounting #175
+57
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ashima-Ashima1 <[email protected]>
Signed-off-by: Ashima-Ashima1 <[email protected]>
mssachan
requested changes
May 14, 2025
pkg/mounter/mounter-s3fs.go
Outdated
|
|
||
| var metaRoot string | ||
| if mountWorker { | ||
| metaRoot = constants.WorkerNodeMounterPath |
There was a problem hiding this comment.
RenameMounter
WorkerNodeMounterPath ---> MounterConfigPathOnHost
pkg/mounter/mounter-s3fs.go
Outdated
| if mountWorker { | ||
| metaRoot = constants.WorkerNodeMounterPath | ||
| } else { | ||
| metaRoot = "/var/lib/ibmc-s3fs" |
There was a problem hiding this comment.
Declare this as constant.
MounterConfigPathOnPod="/var/lib/ibmc-s3fs"
pkg/mounter/mounter-s3fs.go
Outdated
| return nil | ||
| } | ||
| klog.Info("NodeServer Unmounting...") | ||
| return s3fs.MounterUtils.FuseUnmount(target) | ||
| err = s3fs.MounterUtils.FuseUnmount(target) |
There was a problem hiding this comment.
Move this logic to else section and keep password file deletion logic at one place only at the end.
Signed-off-by: Ashima-Ashima1 <[email protected]>
Signed-off-by: Ashima-Ashima1 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Issue ticket number and link
Checklist before requesting a review