enable static pv to create in dynamic way #1288

badri-pathak · 2025-02-12T14:44:58Z

Pull request checklist

This feature enables static provisioning within a dynamic provisioning framework, enhancing existing static provisioning capabilities to support additional CSI features such as expansion, snapshots, cloning, and restore for IBM Storage Scale.

This PR is related to the feature discussion at the issue https://github.ibm.com/IBMSpectrumScale/scale-core/issues/8017

Design Doc: Feature to provision a static pv in a dynamic way

Pull request type

Please check the type of change your PR introduces:

What is the current behavior?

In the current behavior, With static provisioning, the cluster administrator has to manually provision the storage and create the persistent volume (PV) object followed by persistent volume claim (PVC) for thier application workload.

What is the new behavior?

Administrators use static provisioning in a dynamic volume provisioning to provides and shares access to preexisting data in IBM Storage Scale. With static provisioning in a dynamic provisioning, a cluster administrator only needs to create a storage class (or multiple storage classes) for a pre-exist data to get automatically mapped with new provisioned volume PV and created on-demand for each user's PVC request.

How risky is this change?

Small, isolated change
Medium, requires regression testing
Large, requires functional and regression testing

Signed-off-by: badri-pathak <[email protected]>

badri-pathak · 2025-02-12T14:49:52Z

~~Image: quay.io/badri_pathak/ibm-spectrum-scale-csi-driver:staticpv_22~~

Signed-off-by: badri-pathak <[email protected]>

badri-pathak · 2025-02-14T14:38:12Z

~~image: quay.io/badri_pathak/ibm-spectrum-scale-csi-driver:staticpv_24~~

Signed-off-by: badri-pathak <[email protected]>

driver/csiplugin/gpfs_util.go

...er/examples/version1/volume/dynamicprovisioning/staticprovisioning/dependent/static_pod.yaml

driver/csiplugin/controllerserver.go

Signed-off-by: badri-pathak <[email protected]>

badri-pathak · 2025-02-22T20:41:03Z

~~image: quay.io/badri_pathak/ibm-spectrum-scale-csi-driver:staticpv_25~~

Signed-off-by: badri-pathak <[email protected]>

saurabhwani5

Hi @badri-pathak , please have a look on issue 8396 in scale core

Signed-off-by: badri-pathak <[email protected]>

badri-pathak · 2025-03-19T14:55:06Z

with volume attribute class support
driver image: quay.io/badri_pathak/ibm-spectrum-scale-csi-driver:staticpv_34

Signed-off-by: badri-pathak <[email protected]>

badri-pathak · 2025-03-20T13:35:47Z

~~Image: quay.io/badri_pathak/ibm-spectrum-scale-csi-driver:staticpv_41~~

Signed-off-by: badri-pathak <[email protected]>

badri-pathak · 2025-03-25T10:25:46Z

~~Image: quay.io/badri_pathak/ibm-spectrum-scale-csi-driver:staticpv_42~~

Signed-off-by: badri-pathak <[email protected]>

hemalathagajendran · 2025-03-28T11:21:02Z

driver/csiplugin/gpfs_util.go

@@ -413,7 +440,13 @@ func getScaleVolumeOptions(ctx context.Context, volOptions map[string]string) (*
 		scaleVol.NodeClass = nodeClass
 	}

-	if isCGSpecified {
+	if scaleVol.IsStaticPVBased {


if condition for static pv and else condition has the same code. can we combine it together

addressed the comment

hemalathagajendran · 2025-03-28T11:51:15Z

driver/csiplugin/controllerserver.go

@@ -2066,6 +2226,87 @@ func (cs *ScaleControllerServer) validateCloneRequest(ctx context.Context, scale
 		}
 	}

+	/*	if sourcevolume.StorageClassType == STORAGECLASS_CLASSIC {


Is this commented code required?

removed the comments.

driver/csiplugin/controllerserver.go

Signed-off-by: badri-pathak <[email protected]>

badri-pathak · 2025-03-28T13:06:39Z

Image: quay.io/badri_pathak/ibm-spectrum-scale-csi-driver:staticpv_44

hemalathagajendran · 2025-03-28T13:10:26Z

driver/csiplugin/controllerserver.go

+				klog.Infof("[%s] ControllerModifyVolume: Modify filesetName:[ %s ] using VolumeAttributeClass is not allowed, so returning success \n", loggerId, filesetName)
+				return &csi.ControllerModifyVolumeResponse{}, nil
+			}
+		} else if volumeIDMembers.StorageClassType != STORAGECLASS_CACHE {


Need to correct the error msg as volume attribute class is supported for cache volumes

Signed-off-by: badri-pathak <[email protected]>

badri-pathak added 2 commits February 12, 2025 06:44

enable static pv to create in dynamic way

9be344d

Signed-off-by: badri-pathak <[email protected]>

Merge remote-tracking branch 'upstream/dev' into static_pv_to_dynamic

9640f2d

badri-pathak requested review from hemalathagajendran and deeghuge February 12, 2025 14:48

badri-pathak added this to the v2.14.0 milestone Feb 12, 2025

badri-pathak requested review from Jainbrt and saurabhwani5 February 13, 2025 10:19

Jainbrt and others added 4 commits February 13, 2025 16:49

Merge branch 'dev' into static_pv_to_dynamic

b18a751

Merge branch 'dev' into static_pv_to_dynamic

ec6371c

static target shouldn't allowed for snapsource or volsource

97fbb2b

Signed-off-by: badri-pathak <[email protected]>

expand volume should increase quota is already set

bb8374d

Signed-off-by: badri-pathak <[email protected]>

code refine

793d8c5

Signed-off-by: badri-pathak <[email protected]>

hemalathagajendran reviewed Feb 22, 2025

View reviewed changes

driver/csiplugin/gpfs_util.go Show resolved Hide resolved

...er/examples/version1/volume/dynamicprovisioning/staticprovisioning/dependent/static_pod.yaml Outdated Show resolved Hide resolved

driver/csiplugin/controllerserver.go Outdated Show resolved Hide resolved

review comments

63f73be

Signed-off-by: badri-pathak <[email protected]>

Jainbrt and others added 6 commits February 24, 2025 14:35

Merge branch 'dev' into static_pv_to_dynamic

71c3d92

Merge branch 'dev' into static_pv_to_dynamic

7ab9c53

moved yamls at main directory

6ee48b3

Signed-off-by: badri-pathak <[email protected]>

added dockerignore file not to build when examples got changed

2ed4948

Signed-off-by: badri-pathak <[email protected]>

Merge branch 'dev' into static_pv_to_dynamic

ce314ea

moved yamls at main directory

2cb9371

Signed-off-by: badri-pathak <[email protected]>

hemalathagajendran previously approved these changes Feb 26, 2025

View reviewed changes

Jainbrt and others added 3 commits February 26, 2025 20:17

Merge branch 'dev' into static_pv_to_dynamic

60c8947

Merge branch 'dev' into static_pv_to_dynamic

89eaea6

Merge branch 'dev' into static_pv_to_dynamic

e0634ed

saurabhwani5 reviewed Mar 13, 2025

View reviewed changes

badri-pathak added 2 commits March 13, 2025 12:11

Merge branch 'dev' into static_pv_to_dynamic

a1e7f3e

Merge branch 'dev' into static_pv_to_dynamic

29d8bee

fileset name can be provided using volumeattributeclass

c92b3e8

Signed-off-by: badri-pathak <[email protected]>

badri-pathak added 2 commits March 19, 2025 07:56

fileset name can be provided using volumeattributeclass

5db0514

Signed-off-by: badri-pathak <[email protected]>

blocking shallow copy creation from static source

105019f

Signed-off-by: badri-pathak <[email protected]>

Merge branch 'dev' into static_pv_to_dynamic

82113d0

Jainbrt requested review from hemalathagajendran and saurabhwani5 March 25, 2025 03:09

badri-pathak added 2 commits March 24, 2025 23:47

Merge remote-tracking branch 'upstream/dev' into static_pv_to_dynamic

53943a4

Signed-off-by: badri-pathak <[email protected]>

accomodate filesetcomment changes into staticvolume pr

2be0bc9

Signed-off-by: badri-pathak <[email protected]>

added shallow copy example file

1540041

Signed-off-by: badri-pathak <[email protected]>

saurabhwani5 previously approved these changes Mar 27, 2025

View reviewed changes

Merge branch 'dev' into static_pv_to_dynamic

0303754

Jainbrt previously approved these changes Mar 27, 2025

View reviewed changes

hemalathagajendran reviewed Mar 28, 2025

View reviewed changes

driver/csiplugin/controllerserver.go Show resolved Hide resolved

badri-pathak added 3 commits March 28, 2025 18:25

Merge branch 'dev' into static_pv_to_dynamic

e366a41

addressed review comment

df09fd4

Signed-off-by: badri-pathak <[email protected]>

addressed review comment and issue 8443

957f593

Signed-off-by: badri-pathak <[email protected]>

badri-pathak dismissed stale reviews from Jainbrt and saurabhwani5 via 957f593 March 28, 2025 13:01

hemalathagajendran reviewed Mar 28, 2025

View reviewed changes

badri-pathak and others added 3 commits March 28, 2025 06:13

addressed review comment

c4f20d2

Signed-off-by: badri-pathak <[email protected]>

addressed review comment

f1d8d5d

Signed-off-by: badri-pathak <[email protected]>

Merge branch 'dev' into static_pv_to_dynamic

7a2b1d1

hemalathagajendran approved these changes Mar 28, 2025

View reviewed changes

saurabhwani5 merged commit 09db274 into IBM:dev Mar 28, 2025
2 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

enable static pv to create in dynamic way #1288

enable static pv to create in dynamic way #1288

badri-pathak commented Feb 12, 2025 •

edited

Loading

badri-pathak commented Feb 12, 2025 •

edited

Loading

badri-pathak commented Feb 14, 2025 •

edited

Loading

badri-pathak commented Feb 22, 2025 •

edited

Loading

saurabhwani5 left a comment •

edited

Loading

badri-pathak commented Mar 19, 2025 •

edited

Loading

badri-pathak commented Mar 20, 2025 •

edited

Loading

badri-pathak commented Mar 25, 2025 •

edited

Loading

hemalathagajendran Mar 28, 2025

badri-pathak Mar 28, 2025

hemalathagajendran Mar 28, 2025

badri-pathak Mar 28, 2025

badri-pathak commented Mar 28, 2025

hemalathagajendran Mar 28, 2025

badri-pathak Mar 28, 2025

enable static pv to create in dynamic way #1288

enable static pv to create in dynamic way #1288

Conversation

badri-pathak commented Feb 12, 2025 • edited Loading

Pull request checklist

Pull request type

What is the current behavior?

What is the new behavior?

How risky is this change?

badri-pathak commented Feb 12, 2025 • edited Loading

badri-pathak commented Feb 14, 2025 • edited Loading

badri-pathak commented Feb 22, 2025 • edited Loading

saurabhwani5 left a comment • edited Loading

Choose a reason for hiding this comment

badri-pathak commented Mar 19, 2025 • edited Loading

badri-pathak commented Mar 20, 2025 • edited Loading

badri-pathak commented Mar 25, 2025 • edited Loading

hemalathagajendran Mar 28, 2025

Choose a reason for hiding this comment

badri-pathak Mar 28, 2025

Choose a reason for hiding this comment

hemalathagajendran Mar 28, 2025

Choose a reason for hiding this comment

badri-pathak Mar 28, 2025

Choose a reason for hiding this comment

badri-pathak commented Mar 28, 2025

hemalathagajendran Mar 28, 2025

Choose a reason for hiding this comment

badri-pathak Mar 28, 2025

Choose a reason for hiding this comment

badri-pathak commented Feb 12, 2025 •

edited

Loading

badri-pathak commented Feb 12, 2025 •

edited

Loading

badri-pathak commented Feb 14, 2025 •

edited

Loading

badri-pathak commented Feb 22, 2025 •

edited

Loading

saurabhwani5 left a comment •

edited

Loading

badri-pathak commented Mar 19, 2025 •

edited

Loading

badri-pathak commented Mar 20, 2025 •

edited

Loading

badri-pathak commented Mar 25, 2025 •

edited

Loading