Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed issue for comments for cg independent fileset #1312

Merged
merged 2 commits into from
Mar 28, 2025

Conversation

badri-pathak
Copy link
Member

@badri-pathak badri-pathak commented Mar 27, 2025

Signed-off-by: badri-pathak [email protected]

This is to handle the issue where Independent fileset comment was wrong, as it took fileset name of the very first cg based fileset.

Pull request checklist


Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature Enhancement
  • Test Automation
  • Code Refactoring (no functional changes, no api changes)
  • Build related changes
  • Community Operator listing
  • Other (please describe):

What is the current behavior?

  • The independent fset created during the very first version-2 fset creation was being taken as fsetName during the comment of independentFset also.

What is the new behavior?

  • Every fileset will have their own fileset name in the comment.
image

How risky is this change?

  • Small, isolated change
  • Medium, requires regression testing
  • Large, requires functional and regression testing

@badri-pathak
Copy link
Member Author

Image: quay.io/badri_pathak/ibm-spectrum-scale-csi-driver:issue8456_v1

@badri-pathak badri-pathak added this to the v2.14.0 milestone Mar 27, 2025
Copy link
Member

@saurabhwani5 saurabhwani5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one suggestion @badri-pathak ,
can we change PVC [ fbfddaaa-ab7c-4049-8c62-1ee8d32dec87-default ] , because it is just a fileset and there is no pvc in default namespace for it

@Jainbrt @deeghuge need your help to add appropriate comment for CG parent filest

fbfddaaa-ab7c-4049-8c62-1ee8d32dec87-default 9 3670019 0 Thu Mar 27 19:56:34 2025 7 1048576 12288 Fileset created by IBM Container Storage Interface driver for PVC [ fbfddaaa-ab7c-4049-8c62-1ee8d32dec87-default ] in the namespace [ default ]

@badri-pathak
Copy link
Member Author

@saurabhwani5 Lets create an issue for this, we can take it later also.

@hemalathagajendran
Copy link
Member

@badri-pathak Merge this PR once the above comment is discussed and closed

@badri-pathak badri-pathak changed the title fixed issue for comments for cg independent fileset - issue 8456 fixed issue for comments for cg independent fileset Mar 28, 2025
@Jainbrt Jainbrt merged commit 8e8086d into IBM:dev Mar 28, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants