Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

initial editorial review #2

Merged
merged 1 commit into from
Aug 18, 2023
Merged

initial editorial review #2

merged 1 commit into from
Aug 18, 2023

Conversation

SirSpidey
Copy link
Contributor

Review of the hand-on lab.

DRAFT PR: Haven't gotten to the steps yet.

Reasons for changes

  • Not allowed to add 's to trademarks like IBM Cloud
  • Changes to adhere to official names and capitalization (IBM Cloud projects, deployable architecture)
  • Lead-in sentences to lists should be full sentences
  • Trying to simplify language or sentence length for readability
  • Prefer Sentence case over Title Case
  • Sidebar: make the text parallel

Let me know if there's anything in this approach that doesn't work

@SirSpidey
initial editorial review
bd70137 
Signed-off-by: Allen Dean <[email protected]>
@SirSpidey SirSpidey marked this pull request as ready for review August 18, 2023 12:17
@vburckhardt vburckhardt merged commit 1bb1f9e into IBM:doc-updates Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vburckhardt vburckhardt vburckhardt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SirSpidey @vburckhardt