Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#111 Pass tool version to dockerfile #112

Merged
merged 9 commits into from
Jan 21, 2025
Merged

#111 Pass tool version to dockerfile #112

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
23c303f
Fixes #109 move pip install at the end of the .Dockerfile
kkazmierczyk Jan 16, 2025
a4bb812
Added --root-user-action ignore to .Dockerfile
kkazmierczyk Jan 16, 2025
dc1a921
Fixes #111 pass tool version to Dockerfile
kkazmierczyk Jan 16, 2025
f02eb2d
Ref #111 updated documentation to pass ARG for building Containers.
kkazmierczyk Jan 16, 2025
73bee70
Merge remote-tracking branch 'origin/main' into 111--pass-tool-versio…
kkazmierczyk Jan 17, 2025
4c21b82
Ref #111 Merge with Main
kkazmierczyk Jan 17, 2025
0c6dc8f
Ref #112 corrected Dockerfile to add ENTRYPOINT and add some commands…
kkazmierczyk Jan 17, 2025
4ce0e44
Ref #112 changed back to CMD in Dockerfile
kkazmierczyk Jan 17, 2025
36db5a3
Ref #112 changed back have RUN before CMD
kkazmierczyk Jan 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,11 @@ or

`docker build -t javacore-analyser .`

If you want to build a particular version, you need to add `--build-arg version=` argument, for example:
`podman build --build-arg version='==2.1' -t javacore-analyser .`
or
`podman build --build-arg version='<2.1' -t javacore-analyser .`

To start the container:
`podman run -it --rm --name javacore-analyser --mount type=bind,src="local-dir-on-fs",target=/reports -p 5001:5000 javacore-analyser`

Expand Down
7 changes: 5 additions & 2 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#
# Copyright IBM Corp. 2024 - 2024
# Copyright IBM Corp. 2024 - 2025
# SPDX-License-Identifier: Apache-2.0
#

Expand All @@ -13,5 +13,8 @@ EXPOSE 5000/tcp
RUN mkdir /reports
VOLUME ["/reports"]

RUN ["pip", "install", "--no-cache-dir", "javacore-analyser"]
# As default we do not set the version to have the latest one for build.
ARG version=
#RUN ["pip", "install", "--no-cache-dir", "--root-user-action", "ignore", "javacore-analyser${version}"]
RUN pip install --no-cache-dir --root-user-action ignore javacore-analyser${version}
CMD ["javacore_analyser_web", "--port=5000", "--reports-dir=/reports"]
Loading