fix(helm): add missing metrics configuration to values.schema.json #1382
+39
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR IBM#1313 added metrics configuration to values.yaml but did not update values.schema.json, causing helm template validation to fail with: 'Additional property metrics is not allowed' This commit adds the metrics property definition to the schema including: - enabled: boolean to toggle metrics collection - port: integer for metrics endpoint port - serviceMonitor: object for Prometheus Operator integration - customLabels: object for custom metric labels Fixes schema validation error introduced in PR IBM#1313 Related to Feature IBM#218 (Prometheus Metrics Instrumentation) Signed-off-by: ppippi-dev <[email protected]>
ppippi-dev
force-pushed
the
fix/helm-schema-metrics
branch
from
4c22a10 to
c82092d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐛 Bug Description
Helm template validation fails with schema error after PR #1313 merged:
Error: values don't meet the specifications of the schema(s) in the following chart(s): mcp-stack:
mcpContextForge: Additional property metrics is not allowed
🔍 Root Cause
PR #1313 (Prometheus Metrics Instrumentation - Feature #218) added the
metricsconfiguration tovalues.yamlbut did not update the corresponding JSON schema invalues.schema.json.✅ Solution
Add the missing
metricsproperty definition tovalues.schema.jsonundermcpContextForgeproperties, including:🧪 Testing
Verified the fix by running Helm template validation: