Update job-migration.yaml #1629
Open
+1
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed the Helm template so imagePullSecrets is only defined at the pod level (not inside the container), eliminating the warning about spec.template.spec.containers[0].imagePullSecrets.
The mcp-gateway-mcp-stack-migration Job is a Helm pre-install hook, so it runs before Helm creates the Postgres Deployment/Service/PVC. Because Postgres isn’t created yet, the job keeps failing to connect to mcp-gateway-mcp-stack-postgres, and the failed pre-install hook prevents Helm from installing the rest of the resources. Switched the migration Job to run after install/upgrade so Postgres is already up before migrations run.
Author
|
Also fixed the below issue: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the Helm template so imagePullSecrets is only defined at the pod level (not inside the container), eliminating the warning about spec.template.spec.containers[0].imagePullSecrets.
🐛 Bug-fix PR
Before opening this PR please:
make lint- passesruff,mypy,pylintmake test- all unit + integration tests greenmake coverage- ≥ 90 %make docker docker-run-sslormake podman podman-run-ssl📌 Summary
It fixes the below warning when trying to deploy using helm:
"Warning: unknown field "spec.template.spec.containers[0].imagePullSecrets""
🔁 Reproduction Steps
Run the helm install command to deploy on K8S or OCP cluster.
🐞 Root Cause
The job-migration.yaml file (charts/mcp-stack/templates/job-migration.yaml) has the imagePullSecrets inside 'containers' section; which is incorrect. This is triggering the warning.
💡 Fix Description
Fixed the Helm template so imagePullSecrets is only defined at the pod level (not inside the container), eliminating the warning about spec.template.spec.containers[0].imagePullSecrets.
🧪 Verification
make lintmake testmake coverage📐 MCP Compliance (if relevant)
✅ Checklist
make black isort pre-commit)