[FIX][UI]: Remove non-functional Show/Hide toggle buttons from admin UI#3508
Merged
crivetimihai merged 2 commits intomainfrom Mar 10, 2026
Merged
[FIX][UI]: Remove non-functional Show/Hide toggle buttons from admin UI#3508crivetimihai merged 2 commits intomainfrom
crivetimihai merged 2 commits intomainfrom
Conversation
claudia-gray
changed the title
crivetimihai
changed the title
crivetimihai
added
the
SHOULD
Member
|
Thanks @claudia-gray. Clean removal of the dead |
claudia-gray
force-pushed
the
2968-remove-non-functional-buttons
branch
from
74b288f to
b564390
Compare
…levant to token generation Signed-off-by: Claudia Gray <claudiag082004@gmail.com>
The Show/Hide toggle buttons were removed but their corresponding pr-16 (padding-right) CSS class was left on 8 credential inputs, causing unnecessary empty space. Remove to match virtual server auth field styling. Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>
crivetimihai
force-pushed
the
2968-remove-non-functional-buttons
branch
from
74da914 to
53cbfe5
Compare
Member
|
Great work on this fix, @claudia-gray! 🎉 Rebased onto latest All 822 JS tests pass, and the styling is now consistent with how virtual server auth fields are handled (no extra padding, no toggle buttons). Looks good — nice clean fix for #2968! |
crivetimihai
approved these changes
Mar 10, 2026
mitica
pushed a commit
to mitica/mcp-context-forge
that referenced
this pull request
Mar 10, 2026
…UI (IBM#3508) * Remove non-functional Show/Hide toggle buttons from admin UI page, relevant to token generation Signed-off-by: Claudia Gray <claudiag082004@gmail.com> * fix(ui): remove leftover pr-16 padding from credential inputs The Show/Hide toggle buttons were removed but their corresponding pr-16 (padding-right) CSS class was left on 8 credential inputs, causing unnecessary empty space. Remove to match virtual server auth field styling. Signed-off-by: Mihai Criveti <crivetimihai@gmail.com> --------- Signed-off-by: Claudia Gray <claudiag082004@gmail.com> Signed-off-by: Mihai Criveti <crivetimihai@gmail.com> Co-authored-by: Mihai Criveti <crivetimihai@gmail.com> Signed-off-by: Dumitru C <canteadumitru@gmail.com>
gandhipratik203
added a commit
that referenced
this pull request
Mar 10, 2026
…base PR #3508 removed non-functional Show/Hide toggle buttons from admin.html. After rebasing on main, re-add the buttons to the Edit Gateway form only, now wired to the working async toggleInputMask() that calls the POST /admin/gateways/{id}/reveal-credentials endpoint. Also fix button state reset in editGateway() so reopening the Edit dialog always shows the correct initial "Show" label with token masked. Add form intentionally excluded — no stored secret exists at creation time. Signed-off-by: Pratik Gandhi <gandhipratik203@gmail.com>
MohanLaksh
pushed a commit
that referenced
this pull request
Mar 12, 2026
…UI (#3508) * Remove non-functional Show/Hide toggle buttons from admin UI page, relevant to token generation Signed-off-by: Claudia Gray <claudiag082004@gmail.com> * fix(ui): remove leftover pr-16 padding from credential inputs The Show/Hide toggle buttons were removed but their corresponding pr-16 (padding-right) CSS class was left on 8 credential inputs, causing unnecessary empty space. Remove to match virtual server auth field styling. Signed-off-by: Mihai Criveti <crivetimihai@gmail.com> --------- Signed-off-by: Claudia Gray <claudiag082004@gmail.com> Signed-off-by: Mihai Criveti <crivetimihai@gmail.com> Co-authored-by: Mihai Criveti <crivetimihai@gmail.com>
gandhipratik203
added a commit
that referenced
this pull request
Mar 12, 2026
…base PR #3508 removed non-functional Show/Hide toggle buttons from admin.html. After rebasing on main, re-add the buttons to the Edit Gateway form only, now wired to the working async toggleInputMask() that calls the POST /admin/gateways/{id}/reveal-credentials endpoint. Also fix button state reset in editGateway() so reopening the Edit dialog always shows the correct initial "Show" label with token masked. Add form intentionally excluded — no stored secret exists at creation time. Signed-off-by: Pratik Gandhi <gandhipratik203@gmail.com>
Yosiefeyob
pushed a commit
that referenced
this pull request
Mar 13, 2026
…UI (#3508) * Remove non-functional Show/Hide toggle buttons from admin UI page, relevant to token generation Signed-off-by: Claudia Gray <claudiag082004@gmail.com> * fix(ui): remove leftover pr-16 padding from credential inputs The Show/Hide toggle buttons were removed but their corresponding pr-16 (padding-right) CSS class was left on 8 credential inputs, causing unnecessary empty space. Remove to match virtual server auth field styling. Signed-off-by: Mihai Criveti <crivetimihai@gmail.com> --------- Signed-off-by: Claudia Gray <claudiag082004@gmail.com> Signed-off-by: Mihai Criveti <crivetimihai@gmail.com> Co-authored-by: Mihai Criveti <crivetimihai@gmail.com> Signed-off-by: Yosief Eyob <yosiefogbazion@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Claudia Gray claudiag082004@gmail.com
🔗 Related Issue
Closes #2968
📝 Summary
This PR removes the non-functional ‘Show/Hide’ toggle buttons from the UI in admin.html. Buttons were using a function ‘ToggleInputMask’ that no longer exists and therefore serve no purpose.
🏷️ Type of Change
Fixed By
Fixed using suggestion from: #2968 (comment)
TLDR: Deleting Show buttons
🧪 Verification
Ran tests from test_bash.txt sent into slack. https://ibm-cloud.slack.com/archives/C0A71H6HMAN/p1772704889538949
📓 Notes (optional)
Before: (Screenshot is from original issue #2968
After: (Screenshot is from my local server)
