feat: expose token_endpoint_auth_method in gateway admin UI#3994
Open
ecthelion77 wants to merge 1 commit intoIBM:mainfrom
Open
feat: expose token_endpoint_auth_method in gateway admin UI#3994ecthelion77 wants to merge 1 commit intoIBM:mainfrom
ecthelion77 wants to merge 1 commit intoIBM:mainfrom
Conversation
f8d478c to
76e5fb2
Compare
Contributor
Author
|
Suggested labels: |
76e5fb2 to
a4986de
Compare
7930688 to
ada83d8
Compare
…RFC 6749) Signed-off-by: Olivier Gintrand <olivier.gintrand@forterro.com>
ada83d8 to
658df2f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ Feature PR
📌 Summary
Expose the OAuth2
token_endpoint_auth_methodparameter in the gateway add/edit forms, allowing administrators to select betweenclient_secret_post(default) andclient_secret_basic.Some OAuth2 providers (e.g., Freshworks/Freshservice) require
client_secret_basic(HTTP Basic Auth header) instead of the defaultclient_secret_post(credentials in POST body). Without UI support, reconfiguring a gateway through the admin panel silently drops thetoken_endpoint_auth_methodsetting, causing token exchange failures.Fixes #3991
🧭 Type of Feature
💡 Implementation
admin.py: Readoauth_token_endpoint_auth_methodfrom form data in bothadmin_add_gateway()andadmin_edit_gateway(), and include it inoauth_configwhen present.admin.html: Add a<select>dropdown in both the "Add Gateway" and "Edit Gateway" OAuth form sections, with options:client_secret_post— credentials in POST body (default)client_secret_basic— HTTP Basic Auth headeradmin.js: In theeditGateway()function, retrieve and populate the dropdown with the existingtoken_endpoint_auth_methodvalue from the gateway's OAuth config.The backend already supports
token_endpoint_auth_methodinoauth_config— this change only adds the UI surface.🧪 Verification
make lintmake testmake coverageclient_secret_basic, token exchange succeeds. Editing the gateway preserves the setting.📐 MCP Compliance
token_endpoint_auth_methodis defined in RFC 6749 Section 2.3 and RFC 7591 Section 2✅ Checklist