chore: Replace remaining bare uv commands with $(UV_BIN) in Makefile#4123
Merged
chore: Replace remaining bare uv commands with $(UV_BIN) in Makefile#4123
Conversation
2e76a07 to
0b14b4c
Compare
Replaced 71 bare uv commands with $(UV_BIN) for consistent resolution across different installation layouts, following the pattern established in PR #3886. Changes by category: - uv tool install: 2 instances (highest priority - runs outside venv) - uv run: 31 instances - uv pip: 35 instances - uv build: 3 instances This ensures uv is correctly resolved from PATH or ~/.local/bin/uv in all make targets, preventing "No such file or directory" failures. Closes #3946 Signed-off-by: Mohan Lakshmaiah <mohan.economist@gmail.com>
0b14b4c to
50c9009
Compare
claudia-gray
pushed a commit
that referenced
this pull request
Apr 13, 2026
…4123) Replaced 71 bare uv commands with $(UV_BIN) for consistent resolution across different installation layouts, following the pattern established in PR #3886. Changes by category: - uv tool install: 2 instances (highest priority - runs outside venv) - uv run: 31 instances - uv pip: 35 instances - uv build: 3 instances This ensures uv is correctly resolved from PATH or ~/.local/bin/uv in all make targets, preventing "No such file or directory" failures. Closes #3946 Signed-off-by: Mohan Lakshmaiah <mohan.economist@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
PR #3886 introduced
$(UV_BIN)to resolveuvfrom PATH or~/.local/bin/uvand converted 16 call sites. However, ~70 bareuvcommands remained in the Makefile, all subject to the same "No such file or directory" failure whenuvisn't on PATH inside an activated venv or in certain installation layouts.Impact: Build failures across multiple make targets when uv is not directly accessible on PATH.
Closes #3946
Root Cause
When PR #3886 added the
UV_BINvariable to fix uv resolution issues, it only converted the 16 most problematic call sites. The remaining ~70 bareuvcommands (tool install, run, pip, build) were not systematically converted at that time.Solution
Mechanical find-and-replace of all remaining bare
uvcommands with$(UV_BIN), following the established pattern from PR #3886.Why this approach: Simple, consistent with existing pattern, no logic changes required, maintains backward compatibility with all existing developer setups.
Categories replaced:
uv tool install→$(UV_BIN) tool install(highest priority - runs outside venv)uv run→$(UV_BIN) runuv pip→$(UV_BIN) pipuv build→$(UV_BIN) buildImplementation Details
uv tool install: 2 instances (lines 4730, 4735)
sonar-deps-podmantargetsonar-deps-dockertargetuv run: 31 instances
uv pip: 35 instances
uv build: 3 instances (lines 4904, 4920, 4932)
disttarget (full build)wheeltarget (wheel only)sdisttarget (source distribution only)Total: 71 replacements
Testing
✅ Syntax validation: Verified make targets parse correctly
make -n sonar-deps-podman # UV_BIN expanded correctly✅ Pattern verification: Confirmed all bare uv commands replaced
✅ Category breakdown verified:
✅ Git diff verified: 71 deletions, 71 additions (1:1 replacement)
Breaking Changes
None - this maintains backward compatibility with all existing developer setups.
Checklist
uvcommands with $(UV_BIN) in Makefile #3946