Merged
Conversation
Signed-off-by: lucarlig <luca.carlig@ibm.com>
0b92f84 to
b25a03b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🐛 Bug-fix PR
Before opening this PR please:
make lint- passesruff,mypy,pylintmake test- all unit + integration tests greenmake coverage- ≥ 80 %make docker docker-run-sslormake podman podman-run-ssl📌 Summary
Removes machine-specific
/home/cmihaipaths from checked-in scripts, Makefiles, and docs so the repo works across developer environments. Adds a regression test to prevent reintroducing user-specific home paths.🔁 Reproduction Steps
No linked issue.
/home/cmihai.🐞 Root Cause
Several checked-in files captured one developer's local home directory and checkout path instead of using portable path discovery,
$HOME,VIRTUAL_ENV, or repo-relative links.💡 Fix Description
VIRTUAL_ENV, repo.venv, then$HOME/.venv/mcpgateway..venv.🧪 Verification
make lintmake testmake coverageuv run pytest -q tests/unit/test_no_machine_specific_paths.py;rg -n '/home/cmihai' .;bash -n tests/performance/utils/setup-auth.sh;bash -n mcp-servers/python/mcp-rss-search/test_live.sh📐 MCP Compliance (if relevant)
✅ Checklist
make black isort pre-commit)📓 Notes
This is intentionally small and surgical. The remaining generic
/home/userstrings are test fixtures or neutral examples, not machine-specific runtime paths.The standard
detailed-code-reviewworkflow has not been run yet and should happen before marking this draft ready.