Skip to content

chore: remove alpine container references#4170

Merged
jonpspri merged 4 commits intomainfrom
fix/remove-alpine-test-common
Apr 15, 2026
Merged

chore: remove alpine container references#4170
jonpspri merged 4 commits intomainfrom
fix/remove-alpine-test-common

Conversation

@lucarlig
Copy link
Copy Markdown
Collaborator

📌 Summary

This updates the builder compose test fixture to use redis:7-bookworm instead of redis:7-alpine.

🔁 Reproduction Steps

  1. Inspect tests/unit/mcpgateway/tools/builder/test_common.py.
  2. Find the compose infrastructure test fixture that still uses redis:7-alpine.
  3. Compare with the main Rust CI branch work, which already moved branch-local Redis services off Alpine.

🐞 Root Cause

The test fixture still referenced Alpine-based Redis even though the active CI/container changes are moving Redis service images away from Alpine.

💡 Fix Description

Replaced the fixture value with redis:7-bookworm. No production code changed.

🧪 Verification

Check Command Status
Focused unit test uv run pytest -q tests/unit/mcpgateway/tools/builder/test_common.py -k infrastructure

📐 MCP Compliance (if relevant)

  • Matches current MCP spec
  • No breaking change to MCP clients

✅ Checklist

  • Code formatted (make black isort pre-commit)
  • No secrets/credentials committed

@lucarlig lucarlig added the release-fix Critical bugfix required for the release label Apr 14, 2026
@lucarlig lucarlig changed the title test: remove alpine redis fixture chore: remove alpine container references Apr 14, 2026
lucarlig and others added 4 commits April 15, 2026 14:01
Signed-off-by: lucarlig <luca.carlig@ibm.com>
Signed-off-by: lucarlig <luca.carlig@ibm.com>
(cherry picked from commit 8f04cda)
Signed-off-by: lucarlig <luca.carlig@ibm.com>
Signed-off-by: Jonathan Springer <jps@s390x.com>
@jonpspri jonpspri force-pushed the fix/remove-alpine-test-common branch from 5394614 to 9eefc88 Compare April 15, 2026 13:05
@jonpspri jonpspri merged commit f41f2aa into main Apr 15, 2026
30 checks passed
@jonpspri jonpspri deleted the fix/remove-alpine-test-common branch April 15, 2026 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-fix Critical bugfix required for the release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants