Skip to content

fix(ui): npm vulnerabilities#4366

Merged
jonpspri merged 3 commits intomainfrom
4365-fix-npm-vulnerabilities
Apr 22, 2026
Merged

fix(ui): npm vulnerabilities#4366
jonpspri merged 3 commits intomainfrom
4365-fix-npm-vulnerabilities

Conversation

@marekdano
Copy link
Copy Markdown
Collaborator

🔗 Related Issue

Closes #4365


Summary

Fix npm vulnerabilities by running npm audit fix


🏷️ Type of Change

  • Bug fix
  • Feature / Enhancement
  • Documentation
  • Refactor
  • Chore (deps, CI, tooling)
  • Other (describe below)

🧪 Verification

Check Command Status
Lint suite make lint
Unit tests make test
Coverage ≥ 80% make coverage

✅ Checklist

  • Code formatted (make black isort pre-commit)
  • Tests added/updated for changes
  • Documentation updated (if applicable)
  • No secrets or credentials committed

📓 Notes (optional)

Screenshots, design decisions, or additional context.

Copy link
Copy Markdown
Collaborator

@gcgoncalves gcgoncalves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be worth adding this to the package.json's resolve?

@marekdano marekdano requested a review from gcgoncalves April 21, 2026 12:46
@marekdano marekdano changed the title fix: npm vulnerabilities fix(ui): npm vulnerabilities Apr 21, 2026
Marek Dano added 2 commits April 21, 2026 15:00
Signed-off-by: Marek Dano <Marek.Dano@ibm.com>
Signed-off-by: Marek Dano <Marek.Dano@ibm.com>
@gcgoncalves gcgoncalves force-pushed the 4365-fix-npm-vulnerabilities branch from b0aa013 to 021f579 Compare April 21, 2026 14:00
@marekdano marekdano added this to the Release 1.0.0 milestone Apr 22, 2026
@jonpspri jonpspri merged commit 3890427 into main Apr 22, 2026
20 checks passed
@jonpspri jonpspri deleted the 4365-fix-npm-vulnerabilities branch April 22, 2026 19:20
gcgoncalves pushed a commit that referenced this pull request Apr 23, 2026
* fix: npm vulnerabilities

Signed-off-by: Marek Dano <Marek.Dano@ibm.com>

* fix: bump basic-ftp in package.json overrides

Signed-off-by: Marek Dano <Marek.Dano@ibm.com>

---------

Signed-off-by: Marek Dano <Marek.Dano@ibm.com>
Co-authored-by: Marek Dano <Marek.Dano@ibm.com>
Co-authored-by: Jonathan Springer <jps@s390x.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CHORE]: Fix npm vulnerabilities

4 participants