Tool Metric for /tools/{tool_id} endpoint#5017
Open
ScarAnd wants to merge 4 commits into
Open
Conversation
ScarAnd
requested review from
Lang-Akshay,
brian-hussey,
crivetimihai and
ja8zyjits
as code owners
ScarAnd
changed the title
Signed-off-by: lucarlig <luca.carlig@ibm.com> Merged-by: Jitesh Nair <jiteshnair@ibm.com> Signed-off-by: Andrin Enz <89848517+ScarAnd@users.noreply.github.com>
* chore: update cpex to 0.1.1.dev1 for CopyOnWriteDict support Signed-off-by: prakhar-singh1928 <prakhar.singh1928@ibm.com> * add uv lock file Signed-off-by: prakhar-singh1928 <prakhar.singh1928@ibm.com> --------- Signed-off-by: prakhar-singh1928 <prakhar.singh1928@ibm.com> Merged-by: Jitesh Nair <jiteshnair@ibm.com> Signed-off-by: Andrin Enz <89848517+ScarAnd@users.noreply.github.com>
Signed-off-by: Andrin Enz <89848517+ScarAnd@users.noreply.github.com>
Signed-off-by: Andrin Enz <89848517+ScarAnd@users.noreply.github.com>
ScarAnd
force-pushed
the
add-tool-metric-to-response
branch
from
4ed4ff4 to
591d018
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Related Issue
Closes (no issue assigned)
📝 Summary
What does this PR do and why?
For now the
metricsobject always returns null, as it's default hardcoded. This PR adds an optional boolean query parameter calledinclude_metrics.🏷️ Type of Change
🧪 Verification
make lintmake testmake coverage✅ Checklist
make black isort pre-commit)📓 Notes (optional)
Screenshots, design decisions, or additional context.