fix/rate-limit-root-path-prefix-4994#5018
Open
Nayana-R-Gowda wants to merge 1 commit into
Open
Conversation
Signed-off-by: NAYANA.R <nayana.r7813@gmail.com>
Nayana-R-Gowda
requested review from
Lang-Akshay,
brian-hussey,
crivetimihai and
ja8zyjits
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: NAYANA.R nayana.r7813@gmail.com
closes #4994
Changes Made
mcpgateway/middleware/rate_limit_middleware.py
1.get_endpoint_tier() (line 169): Changed signature from (self, path: str) to (self, request_or_path) — now accepts either a Request object or a string. When a Request is passed, strips the root_path prefix before pattern matching.
2._get_tier_name() (line 295): Same treatment — accepts Request or str, strips root_path when a Request is passed.
3.dispatch() (lines 227, 230): Now passes request directly instead of request.url.path.
tests/unit/mcpgateway/middleware/test_rate_limit_middleware.py
1 .test_endpoint_tier_strips_root_path — 10 cases covering various root_path values and tier types
2 .test_endpoint_tier_root_path_edge_cases — 5 edge cases (trailing slash, / root, partial match prevention, empty root_path)
AFTER:
tier = self.get_endpoint_tier(request)
dimensions = self._get_client_dimensions(request)
tier_name = self._get_tier_name(request)