Skip to content

WIP: Implement backtrace - #2

Draft
kadler wants to merge 1 commit into
mainfrom
backtrace
Draft

WIP: Implement backtrace#2
kadler wants to merge 1 commit into
mainfrom
backtrace

Conversation

@kadler

@kadler kadler commented Mar 15, 2019

Copy link
Copy Markdown
Member

I've added some WIP code I had laying around to truly implement backtrace().

backtrace2.c is closer to backtrace.c, but doesn't compile. backtrace3.c was from my home directory, which does compile, but is from an older version before I cleaned up the comments and layout when I merged the placeholder backtrace.c

backtrace2.c is closer to backtrace.c, but doesn't compile. backtrace3.c
was from my home directory, which does compile, but is from an older
version before I cleaned up the comments and layout when I merged the
placeholder backtrace.c
@abmusse

abmusse commented May 14, 2019

Copy link
Copy Markdown
Member

Are we also going to implement backtrace_symbols_fd #3 ?

@kadler

kadler commented May 28, 2019

Copy link
Copy Markdown
Member Author

We can. It shouldn't be too difficult to make it work just by wrappering backtrace_symbols. The Linux man page says that backtrace_symbols_fd does not call malloc, which would require more work to implement. I did not see the same language in the Solaris, FreeBSD, or macOS man pages, though.

@ThePrez ThePrez left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ThePrez

ThePrez commented Mar 25, 2020

Copy link
Copy Markdown
Member

@kadler , is this one ready to land?

@ThePrez

ThePrez commented Mar 25, 2020

Copy link
Copy Markdown
Member

Nevermind.... I was thinking we could land this one and pursue finishing this all up in a future thing, but that doesn't make a lot of sense

@kadler

kadler commented Mar 25, 2020

Copy link
Copy Markdown
Member Author

No, this is not ready to land. Not really intended to land either, more just to get visibility. Best for someone to take the code from this PR and fix it up in to a separate PR.

@kadler
kadler marked this pull request as draft May 5, 2020 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants