Conversation
backtrace2.c is closer to backtrace.c, but doesn't compile. backtrace3.c was from my home directory, which does compile, but is from an older version before I cleaned up the comments and layout when I merged the placeholder backtrace.c
Member
|
Are we also going to implement |
Member
Author
|
We can. It shouldn't be too difficult to make it work just by wrappering |
Member
|
@kadler , is this one ready to land? |
Member
|
Nevermind.... I was thinking we could land this one and pursue finishing this all up in a future thing, but that doesn't make a lot of sense |
Member
Author
|
No, this is not ready to land. Not really intended to land either, more just to get visibility. Best for someone to take the code from this PR and fix it up in to a separate PR. |
kadler
marked this pull request as draft
May 5, 2020 13:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added some WIP code I had laying around to truly implement backtrace().
backtrace2.c is closer to backtrace.c, but doesn't compile. backtrace3.c was from my home directory, which does compile, but is from an older version before I cleaned up the comments and layout when I merged the placeholder backtrace.c