Security: Arbitrary File Read via read_trace Tauri Command#1615
Open
tomaioo wants to merge 1 commit into
Open
Conversation
The `read_trace` Tauri command in `read_trace.rs` accepts a file path string and directly reads it using `std::fs::read`. There is no path validation, sanitization, or restriction to prevent reading files outside of intended directories. This allows an attacker to read arbitrary files on the system by passing paths like `../../../etc/passwd` or `C:\Windows\System32\config\SAM`. Since this is exposed as a Tauri command, it can be invoked from the frontend JavaScript. Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Security: Arbitrary File Read via read_trace Tauri Command
Problem
Severity:
High| File:pdl-live-react/src-tauri/src/commands/read_trace.rs:L1The
read_traceTauri command inread_trace.rsaccepts a file path string and directly reads it usingstd::fs::read. There is no path validation, sanitization, or restriction to prevent reading files outside of intended directories. This allows an attacker to read arbitrary files on the system by passing paths like../../../etc/passwdorC:\Windows\System32\config\SAM. Since this is exposed as a Tauri command, it can be invoked from the frontend JavaScript.Solution
Validate and restrict the file path to a specific allowed directory. Use
std::path::Path::canonicalizeand ensure the resolved path is within an allowed base directory. Consider using a whitelist or sandbox approach. Also validate that the file extension is.jsonor.pdlas expected.Changes
pdl-live-react/src-tauri/src/commands/read_trace.rs(modified)