Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(test): include kafka 4.0.0 in FV testing #3045

Merged
merged 7 commits into from
Jan 6, 2025
Merged

chore(test): include kafka 4.0.0 in FV testing #3045

merged 7 commits into from
Jan 6, 2025

Conversation

dnwe
Copy link
Collaborator

@dnwe dnwe commented Dec 23, 2024

Whilst 4.0 isn't yet released, in order to allow us to do some up-front testing, compile from src and include in FV runs

Note: we have to include a server.properties for ZooKeeper mode as the 4.0 release no longer includes it. They only ship a Kraft-mode config file and we still want to run in ZooKeeper mode for now as its more convenient for the FV setup to be consistent

@dnwe dnwe changed the title chore(ci): bump to ubi9 and java 17 for ITs chore(test): include kafka 4.0.0 in FV testing Dec 23, 2024
@dnwe dnwe force-pushed the dnwe/kafka-4 branch 2 times, most recently from 8ded8b3 to e5b1907 Compare December 24, 2024 15:59
dnwe added 6 commits December 25, 2024 10:21
Signed-off-by: Dominic Evans <[email protected]>
Whilst 4.0 isn't yet released, in order to allow us to do some up-front
testing, compile from src

Signed-off-by: Dominic Evans <[email protected]>
Don't use the minimum protocol versions here, use something appropriate
for the remote kafka version. In Kafka 4.0.0 the minimum versions are no longer
supported.

Signed-off-by: Dominic Evans <[email protected]>
@dnwe dnwe force-pushed the dnwe/kafka-4 branch 2 times, most recently from 3cb4d48 to 9782bc6 Compare December 27, 2024 11:32
@dnwe dnwe added the chore label Dec 27, 2024
@dnwe dnwe marked this pull request as ready for review December 27, 2024 12:04
@dnwe dnwe requested review from hindessm and prestona December 27, 2024 12:09
Copy link
Collaborator

@hindessm hindessm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dnwe dnwe merged commit 75660e5 into main Jan 6, 2025
15 checks passed
@dnwe dnwe deleted the dnwe/kafka-4 branch January 6, 2025 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants