-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(test): include kafka 4.0.0 in FV testing #3045
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnwe
changed the title
chore(ci): bump to ubi9 and java 17 for ITs
chore(test): include kafka 4.0.0 in FV testing
Dec 23, 2024
dnwe
force-pushed
the
dnwe/kafka-4
branch
2 times, most recently
from
December 24, 2024 15:59
8ded8b3
to
e5b1907
Compare
Signed-off-by: Dominic Evans <[email protected]>
Signed-off-by: Dominic Evans <[email protected]>
Whilst 4.0 isn't yet released, in order to allow us to do some up-front testing, compile from src Signed-off-by: Dominic Evans <[email protected]>
Signed-off-by: Dominic Evans <[email protected]>
Don't use the minimum protocol versions here, use something appropriate for the remote kafka version. In Kafka 4.0.0 the minimum versions are no longer supported. Signed-off-by: Dominic Evans <[email protected]>
Signed-off-by: Dominic Evans <[email protected]>
dnwe
force-pushed
the
dnwe/kafka-4
branch
2 times, most recently
from
December 27, 2024 11:32
3cb4d48
to
9782bc6
Compare
Signed-off-by: Dominic Evans <[email protected]>
hindessm
approved these changes
Jan 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whilst 4.0 isn't yet released, in order to allow us to do some up-front testing, compile from src and include in FV runs
Note: we have to include a server.properties for ZooKeeper mode as the 4.0 release no longer includes it. They only ship a Kraft-mode config file and we still want to run in ZooKeeper mode for now as its more convenient for the FV setup to be consistent