Fix issue #12 #142
Merged
Fix issue #12 #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nicklas Körtge <[email protected]>
hugoqnc
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@hugoqnc I've checked that this doesn't break any other tests in Java, but I haven't checked it for BC. Please do so before we merge this PR.
Should fix #12
How the fix works
If a
shouldBeDetectedAsdefined as part of a detection rule and if this detection should be append as a child to another value (by usingasChildOfParameterWithId(...)) then this detection value does not get the root depending detection rules appended (done withwithDependingDetectionRules).If more then one detection value should be detected on root level (both don't use
asChildOfParameterWithId(...)) then, this will still create duplicated nodes on the lower levels. But as part of the translation procedure, this should be merged automatically.