Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Ollama inference engine #1611

Merged
merged 5 commits into from
Feb 18, 2025
Merged

Fix Ollama inference engine #1611

merged 5 commits into from
Feb 18, 2025

Conversation

eladven
Copy link
Member

@eladven eladven commented Feb 17, 2025

No description provided.

elronbandel
elronbandel requested changes Feb 17, 2025
View reviewed changes
Copy link
Member

@elronbandel elronbandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change maybe to if v is not None?
Also this solution should be in to_dict which suppose in my opinion to return only values that were set by the user and no defaults

@eladven eladven force-pushed the ollama branch 3 times, most recently from 27bedf3 to 3fe7657 Compare February 18, 2025 10:02
@eladven eladven merged commit fbd03a6 into main Feb 18, 2025
11 of 17 checks passed
@eladven eladven deleted the ollama branch February 18, 2025 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elronbandel elronbandel elronbandel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eladven @elronbandel