Fix Azure OpenAI based LLM judges #1619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinscooper
force-pushed
the
fix-azure-llmjudge
branch
from
fba99ac to
a19b215
Compare
Signed-off-by: Martín Santillán Cooper <[email protected]>
The order of the items in a dict changes Signed-off-by: Martín Santillán Cooper <[email protected]>
martinscooper
force-pushed
the
fix-azure-llmjudge
branch
from
a19b215 to
0afe6c6
Compare
elronbandel
approved these changes
Feb 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes Azure OpenAI based LLM judges, where neither the model name nor the api_base was set correctly.
In addition, it does a minor code refactor. This refactor caused the order of the attributes of the inference engine field of the judge's artifacts to change.