Changed API of Key Value Extraction task to use Dict and not List[Tuple] (NON BACKWARD COMPATIBLE CHANGE) #1675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ompare and not List[Tuple[str,str]] Also created a dedicated metric. Signed-off-by: Yoav Katz <[email protected]>
…and not references Signed-off-by: Yoav Katz <[email protected]>
…n KeyValueExtraction Signed-off-by: Yoav Katz <[email protected]>
Signed-off-by: Yoav Katz <[email protected]>
Signed-off-by: Yoav Katz <[email protected]>
Signed-off-by: Yoav Katz <[email protected]>
Signed-off-by: Yoav Katz <[email protected]>
Signed-off-by: elronbandel <[email protected]>
Signed-off-by: elronbandel <[email protected]>
Signed-off-by: Yoav Katz <[email protected]>
Signed-off-by: Yoav Katz <[email protected]>
Signed-off-by: Yoav Katz <[email protected]>
elronbandel
approved these changes
Mar 17, 2025
Signed-off-by: elronbandel <[email protected]>
Signed-off-by: elronbandel <[email protected]>
Also fixed issue when all data was in the cache and an empty list was passed to _infer. Signed-off-by: Yoav Katz <[email protected]>
Signed-off-by: Yoav Katz <[email protected]>
Signed-off-by: elronbandel <[email protected]>
Signed-off-by: elronbandel <[email protected]>
Signed-off-by: Yoav Katz <[email protected]>
Signed-off-by: elronbandel <[email protected]>
Signed-off-by: elronbandel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved key value extraction task and metrics to use Dict[str,str] to compare and not List[Tuple[str,str]]
Also created a dedicated metric.