Fix some bugs in inference engine tests #1682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: elronbandel <[email protected]>
Signed-off-by: elronbandel <[email protected]>
Signed-off-by: elronbandel <[email protected]>
Signed-off-by: elronbandel <[email protected]>
Signed-off-by: elronbandel <[email protected]>
Signed-off-by: elronbandel <[email protected]>
Signed-off-by: elronbandel <[email protected]>
Signed-off-by: elronbandel <[email protected]>
yoavkatz
reviewed
Mar 18, 2025
src/unitxt/api.py
Outdated
| if data_classification_policy is not None: | ||
| args["default_data_classification_policy"] = data_classification_policy | ||
|
|
||
| card = TaskCard(loader=LoadFromDictionary(**args), task=task) |
There was a problem hiding this comment.
why not :
card = TaskCard(loader=LoadFromDictionary(data=data), task=task, data_classification_policy=data_classification_policy) ?
yoavkatz
reviewed
Mar 18, 2025
| "source" in instance | ||
| and isinstance(instance["source"], str) | ||
| and ( | ||
| instance["source"].startswith('[{"role":') |
There was a problem hiding this comment.
This seems very risky, a minor added space, will cause the code to fail. Need to consider alternatives.
Signed-off-by: elronbandel <[email protected]>
Signed-off-by: elronbandel <[email protected]>
1. Use local inference engine on CPU when test inference engine, for reproducability. 2. In cache maechanisim, don't assum that infer on empty list yields empty list. Signed-off-by: Elad Venezian <[email protected]>
Signed-off-by: elronbandel <[email protected]>
Signed-off-by: elronbandel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.