Skip to content

Conversation

@dafnapension
Copy link
Collaborator

@elronbandel
Copy link
Member

Wow great catch! lets hope everything passes 🤞

@dafnapension dafnapension marked this pull request as draft August 5, 2025 17:32
@dafnapension
Copy link
Collaborator Author

dafnapension commented Aug 5, 2025

Turns out that two prepare files can not withstand datasets 4.0.0:
prepare/cards/summarize_from_human_feedback.py and prepare/cards/xsum.py and they fail the run with dataset 4.0.0, while passing alright datasets 3.5.1:
problematic_with_400.pdf

@dafnapension dafnapension force-pushed the remove_ds351_installation branch from e555e6a to eb15a30 Compare August 5, 2025 19:33
Signed-off-by: elronbandel <[email protected]>
@elronbandel elronbandel marked this pull request as ready for review August 6, 2025 10:01
@elronbandel elronbandel changed the title now, with the update needed for datasets 4.0.0, can remove the special installation of 3.5.1 Complete transition to datasets 4.0.0 in preparation tests Aug 6, 2025
@elronbandel elronbandel merged commit 7c4e1f3 into main Aug 6, 2025
18 checks passed
@elronbandel elronbandel deleted the remove_ds351_installation branch August 6, 2025 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants