feat: Add now() and current_timestamp function#1391
Open
anandamideShakyan wants to merge 1 commit intomainfrom
Open
feat: Add now() and current_timestamp function#1391anandamideShakyan wants to merge 1 commit intomainfrom
anandamideShakyan wants to merge 1 commit intomainfrom
Conversation
prestodb-ci
force-pushed
the
main
branch
10 times, most recently
from
b3ffe3f to
a32ad3c
Compare
prestodb-ci
force-pushed
the
main
branch
8 times, most recently
from
7259d87 to
8d72141
Compare
prestodb-ci
force-pushed
the
main
branch
11 times, most recently
from
39be3fb to
c9d5bf2
Compare
prestodb-ci
force-pushed
the
main
branch
19 times, most recently
from
d5b1050 to
5f02206
Compare
prestodb-ci
force-pushed
the
main
branch
8 times, most recently
from
03d0875 to
90fb009
Compare
prestodb-ci
force-pushed
the
main
branch
3 times, most recently
from
09a0047 to
e008bbb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the past, we were not implementing functions like now() that returned constants in Velox. This was because Presto Java would infer the constant value at the co-ordinator and fold it, so the worker was never passed this function in execution.
However, with recent changes for side-car and worker based constant folding implementation, we need native implementations for functions like now(), so adding to Velox as well.