Open
Conversation
Collaborator
Author
|
alchemy rebase @2026-03-23T21:37:29Z |
Collaborator
|
Invalid alchemy verb: rebase |
Collaborator
Author
|
alchemy merge @2026-03-23T21:37:29Z |
Collaborator
|
alchemy link 4f10953 @2026-03-23T21:37:29Z |
Collaborator
|
Added new rebase item:
|
This was referenced Mar 23, 2026
Collaborator
|
Failed to cherry-pick commit 4f10953ed72ae8faceb01374b77531d2612e493b in rebase request #1841: Please:
|
1 task
unidevel
force-pushed
the
ibm-iceberg-new
branch
2 times, most recently
from
4f10953 to
83bb267
Compare
Collaborator
Author
|
alchemy link 83bb26744 @2026-03-24T15:53:57Z |
Collaborator
|
The following unexpired item was removed at
Added new rebase item:
|
This was referenced Mar 24, 2026
Collaborator
|
Failed to cherry-pick commit 83bb26744 in rebase request #1850: Please:
|
1 task
unidevel
force-pushed
the
ibm-iceberg-new
branch
from
83bb267 to
d8b1672
Compare
This was referenced Apr 11, 2026
mohsaka
force-pushed
the
ibm-iceberg-new
branch
from
56e9a01 to
0e0bf94
Compare
Co-authored-by: Li Zhou <unidevel@hotmail.com> Alchemy-item: (ID = 1153) Iceberg staging hub commit 1/6 - c5a69de3d1021073c13a99e1c7c6d6fcce355178 refactor: Move toValues from InPredicate.cpp to Filter.h The function toValues removes duplicated values from the vector and return them in a std::vector. It was used to build an InPredicate. It will be needed for building NOT IN filters for Iceberg equality delete read as well, therefore moving it from velox/functions/prestosql/InPred icate.cpp to velox/type/Filter.h. This commit also renames it to deDuplicateValues to make it easier to understand. feat(connector): Support reading Iceberg split with equality deletes This commit introduces EqualityDeleteFileReader, which is used to read Iceberg splits with equality delete files. The equality delete files are read to construct domain filters or filter functions, which then would be evaluated in the base file readers. When there is only one equality delete field, and when that field is an Iceberg identifier field, i.e. non-floating point primitive types, the values would be converted to a list as a NOT IN domain filter, with the NULL treated separately. This domain filter would then be pushed to the ColumnReaders to filter our unwanted rows before they are read into Velox vectors. When the equality delete column is a nested column, e.g. a sub-column in a struct, or the key in a map, such column may not be in the base file ScanSpec. We need to add/remove these subfields to/from the SchemaWithId and ScanSpec recursively if they were not in the ScanSpec already. A test is also added for such case. If there are more than one equality delete field, or the field is not an Iceberg identifier field, the values would be converted to a typed expression in the conjunct of disconjunts form. This expression would be evaluated as the remaining filter function after the rows are read into the Velox vectors. Note that this only works for Presto now as the "neq" function is not registered by Spark. See https://github.com/ facebookincubator/issues/12667 Note that this commit only supports integral types. VARCHAR and VARBINARY need to be supported in future commits (see facebookincubator#12664). Co-authored-by: Naveen Kumar Mahadevuni <Naveen.Mahadevuni@ibm.com> Alchemy-item: (ID = 1153) Iceberg staging hub commit 2/6 - 14edb98c67f1c572a5f40682923795bd5b08e7c3 Support insert data into iceberg table. Add iceberg partition transforms. Co-authored-by: Chengcheng Jin <Chengcheng.Jin@ibm.com> Add NaN statistics to parquet writer. Collect Iceberg data file statistics in dwio. Integrate Iceberg data file statistics and adding unit test. Support write field_id to parquet metadata SchemaElement. Implement iceberg sort order Add clustered Iceberg writer mode. Fix parquet writer ut Add IcebergConnector Fix unittest error Resolve confict Resolve confict Fix test build issue Fix crash test(Iceberg): Add equality delete tests Co-authored-by: Naveen Kumar Mahadevuni <Naveen.Mahadevuni@ibm.com> Fix stats collection for integer based decimal numbers Co-authored-by: mohsaka <michael.ohsaka@ibm.com> Fix configureReaderOptions in EqualityDeleteFileReader Co-authored-by: Christian Zentgraf <kitgocz@gmail.com>
Collaborator
|
alchemy merge @2026-04-16T02:34:00Z |
Collaborator
|
alchemy link 0e0bf94 @2026-04-16T02:34:00Z |
Collaborator
|
The following unexpired item was removed at
Added new rebase item:
|
mohsaka
force-pushed
the
ibm-iceberg-new
branch
from
0e0bf94 to
07fdcf4
Compare
Collaborator
|
alchemy merge @2026-04-16T02:38:00Z |
Collaborator
|
alchemy link 07fdcf4 @2026-04-16T02:38:00Z |
Collaborator
|
The following unexpired item was removed at
Added new rebase item:
|
This was referenced Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the rebase issue in PR 425
After resolved conflicts, please run the commands to test: