forked from facebookincubator/velox
    
        
        - 
                Notifications
    
You must be signed in to change notification settings  - Fork 4
 
CI Checking - Dummy PR for testing #662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Closed
      
      
    
                
     Closed
            
            
          Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    Signed-off-by: Yuan Zhou <[email protected]> fix concurrent make Signed-off-by: Yuan Zhou <[email protected]> fix cache actions Signed-off-by: Yuan Zhou <[email protected]> fix test concurrency Signed-off-by: Yuan Zhou <[email protected]> increase timeout 6000 Signed-off-by: Yuan Zhou <[email protected]> free disk space Signed-off-by: Yuan Zhou <[email protected]> debug node cleanup Signed-off-by: Yuan Zhou <[email protected]> debug node cleanup Signed-off-by: Yuan Zhou <[email protected]> fix concurrent build job Signed-off-by: Yuan Zhou <[email protected]> exclude velox_exec_test Signed-off-by: Yuan Zhou <[email protected]> fix build concurrency Signed-off-by: Yuan Zhou <[email protected]> restore timeout value Signed-off-by: Yuan Zhou <[email protected]> seperate velox unit tests Signed-off-by: Yuan Zhou <[email protected]> remove unrelated jobs Signed-off-by: Yuan Zhou <[email protected]> remove duplicated cache save Signed-off-by: Yuan Zhou <[email protected]> remove macos workflow Signed-off-by: Yuan Zhou <[email protected]> fix names Signed-off-by: Yuan Zhou <[email protected]> free up disk space Signed-off-by: Yuan Zhou <[email protected]> fix path Signed-off-by: Yuan Zhou <[email protected]> change workdir Signed-off-by: Yuan Zhou <[email protected]> free up more disk space Signed-off-by: Yuan Zhou <[email protected]> verbose output Signed-off-by: Yuan Zhou <[email protected]> disable experimental tests Signed-off-by: Yuan Zhou <[email protected]> fix ctest verbose Signed-off-by: Yuan Zhou <[email protected]> force cache Signed-off-by: Yuan Zhou <[email protected]> trigger Signed-off-by: Yuan Zhou <[email protected]> Revert "disable experimental tests" This reverts commit 13c2e4c. Signed-off-by: Yuan Zhou <[email protected]> fuzz test + release build Signed-off-by: Yuan Zhou <[email protected]> exclude big tests Signed-off-by: Yuan Zhou <[email protected]> Revert "exclude big tests" This reverts commit 5d48dd5. Signed-off-by: Yuan Zhou <[email protected]> fix to use release build Signed-off-by: Yuan Zhou <[email protected]> free up more space Signed-off-by: Yuan Zhou <[email protected]> fix Signed-off-by: Yuan Zhou <[email protected]> increase timeout Signed-off-by: Yuan Zhou <[email protected]> ignore more tests Signed-off-by: Yuan Zhou <[email protected]> fix Signed-off-by: Yuan Zhou <[email protected]> Revert "remove macos workflow" This reverts commit 5ce3d1c. Signed-off-by: Yuan Zhou <[email protected]> fix ubuntu runner Signed-off-by: Yuan Zhou <[email protected]> remove debug build Signed-off-by: Yuan Zhou <[email protected]> remove utils Signed-off-by: Yuan Zhou <[email protected]> adding gluten tests Signed-off-by: Yuan Zhou <[email protected]> disable warning as error on gcc-13 Signed-off-by: Yuan Zhou <[email protected]> seperate gluten jobs Signed-off-by: Yuan Zhou <[email protected]> fix warning Signed-off-by: Yuan Zhou <[email protected]> fix gluten job name Signed-off-by: Yuan Zhou <[email protected]> switch to use ubuntu 2204 Signed-off-by: Yuan Zhou <[email protected]> fix gluten dir Signed-off-by: Yuan Zhou <[email protected]> fix gluten project url Signed-off-by: Yuan Zhou <[email protected]> fix velox branch Signed-off-by: Yuan Zhou <[email protected]> fix cache path Signed-off-by: Yuan Zhou <[email protected]> fix test working dir Signed-off-by: Yuan Zhou <[email protected]> fix arrow lib path Signed-off-by: Yuan Zhou <[email protected]> fix mvn command Signed-off-by: Yuan Zhou <[email protected]> single job for unit tests Signed-off-by: Yuan Zhou <[email protected]> revert non-necessary change Signed-off-by: Yuan Zhou <[email protected]> fix cache key confilict Signed-off-by: Yuan Zhou <[email protected]> fix velox branch Signed-off-by: Yuan Zhou <[email protected]> trigger Signed-off-by: Yuan <[email protected]> exclude merge join test Signed-off-by: Yuan <[email protected]> fxi branch Signed-off-by: Yuan <[email protected]> fix job name Signed-off-by: Yuan <[email protected]> fix velox dir Signed-off-by: Yuan <[email protected]> fix ccache save Signed-off-by: Yuan <[email protected]> remove daily test Signed-off-by: Yuan <[email protected]> remove doc update Signed-off-by: Yuan <[email protected]>
fix decimal avg function precision issue Signed-off-by: Yuan <[email protected]> Alchemy-item: (ID = 478) [6020 ] Spark sql avg agg function support decimal commit 1/1 - a2c648b
Signed-off-by: Yuan <[email protected]> Alchemy-item: (ID = 479) [oap ] Register merge extract companion agg functions without suffix commit 1/1 - 8a8b2b8
Signed-off-by: Yuan <[email protected]> Alchemy-item: (ID = 476) [11067] Support scan filter for decimal in ORC commit 1/1 - b432008
Co-authored-by [email protected] Alchemy-item: (ID = 509) Iceberg staging hub commit 1/7 - e4ebd69
Co-authored-by: Chengcheng Jin <[email protected]> Alchemy-item: (ID = 509) Iceberg staging hub commit 2/7 - 22207d9
Alchemy-item: (ID = 509) Iceberg staging hub commit 3/7 - 2febdd2
Alchemy-item: (ID = 509) Iceberg staging hub commit 4/7 - ed23a63
Alchemy-item: (ID = 509) Iceberg staging hub commit 5/7 - 5acfcc1
The function toValues removes duplicated values from the vector and return them in a std::vector. It was used to build an InPredicate. It will be needed for building NOT IN filters for Iceberg equality delete read as well, therefore moving it from velox/functions/prestosql/InPred icate.cpp to velox/type/Filter.h. This commit also renames it to deDuplicateValues to make it easier to understand. Alchemy-item: (ID = 509) Iceberg staging hub commit 6/7 - 43d82f8
This commit introduces EqualityDeleteFileReader, which is used to read Iceberg splits with equality delete files. The equality delete files are read to construct domain filters or filter functions, which then would be evaluated in the base file readers. When there is only one equality delete field, and when that field is an Iceberg identifier field, i.e. non-floating point primitive types, the values would be converted to a list as a NOT IN domain filter, with the NULL treated separately. This domain filter would then be pushed to the ColumnReaders to filter our unwanted rows before they are read into Velox vectors. When the equality delete column is a nested column, e.g. a sub-column in a struct, or the key in a map, such column may not be in the base file ScanSpec. We need to add/remove these subfields to/from the SchemaWithId and ScanSpec recursively if they were not in the ScanSpec already. A test is also added for such case. If there are more than one equality delete field, or the field is not an Iceberg identifier field, the values would be converted to a typed expression in the conjunct of disconjunts form. This expression would be evaluated as the remaining filter function after the rows are read into the Velox vectors. Note that this only works for Presto now as the "neq" function is not registered by Spark. See https://github.com/ facebookincubator/issues/12667 Note that this commit only supports integral types. VARCHAR and VARBINARY need to be supported in future commits (see facebookincubator#12664). Co-authored-by: Naveen Kumar Mahadevuni <[email protected]> Alchemy-item: (ID = 509) Iceberg staging hub commit 7/7 - 0d33321
Signed-off-by: Yuan <[email protected]> Alchemy-item: (ID = 477) Support struct schema evolution matching by name commit 1/1 - 4ad32f0
…Type Signed-off-by: Yuan <[email protected]> Alchemy-item: (ID = 505) 13620 fix: Add config for requested type check in ReaderBase::convertType commit 1/1 - b5541ba
Signed-off-by: Yuan <[email protected]> Alchemy-item: (ID = 470) [11771] Fix smj result mismatch issue commit 1/1 - d116be8
Signed-off-by: Yuan <[email protected]> Alchemy-item: (ID = 473) fix: Adding daily tests commit 1/1 - d6f0209
Signed-off-by: Yuan <[email protected]> Alchemy-item: (ID = 512) fix: Remove website folder to bypass the security issues commit 1/1 - 67b4dde
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Test github actions for PR: #537