Iceberg refactor into a separate lakehouse connector #996
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmahadevuni
requested review from
jinchengchenghh,
majetideepak and
rui-mo
as code owners
nmahadevuni
force-pushed
the
iceberg-refactor-naveen
branch
from
6b1c246 to
b9f108c
Compare
|
@yingsu00 , please review |
prestodb-ci
force-pushed
the
main
branch
11 times, most recently
from
d7e591c to
a0a0464
Compare
fix decimal avg function precision issue Signed-off-by: Yuan <[email protected]> Alchemy-item: (ID = 518) [6020 ] Spark sql avg agg function support decimal commit 1/1 - 0cd1be1
And reverts facebookincubator#14934 Alchemy-item: (ID = 679) [oap ] Register merge extract companion agg functions without suffix commit 1/1 - 830028e
Address comments disable by default Alchemy-item: (ID = 532) feat: Build hash table while adding input rows for left semi and anti join commit 1/1 - 73ee99f
Signed-off-by: Yuan <[email protected]> Alchemy-item: (ID = 476) [11067] Support scan filter for decimal in ORC commit 1/1 - b432008
The function toValues removes duplicated values from the vector and return them in a std::vector. It was used to build an InPredicate. It will be needed for building NOT IN filters for Iceberg equality delete read as well, therefore moving it from velox/functions/prestosql/InPred icate.cpp to velox/type/Filter.h. This commit also renames it to deDuplicateValues to make it easier to understand. Alchemy-item: (ID = 675) Iceberg staging hub commit 1/12 - 44c99a6
This commit introduces EqualityDeleteFileReader, which is used to read Iceberg splits with equality delete files. The equality delete files are read to construct domain filters or filter functions, which then would be evaluated in the base file readers. When there is only one equality delete field, and when that field is an Iceberg identifier field, i.e. non-floating point primitive types, the values would be converted to a list as a NOT IN domain filter, with the NULL treated separately. This domain filter would then be pushed to the ColumnReaders to filter our unwanted rows before they are read into Velox vectors. When the equality delete column is a nested column, e.g. a sub-column in a struct, or the key in a map, such column may not be in the base file ScanSpec. We need to add/remove these subfields to/from the SchemaWithId and ScanSpec recursively if they were not in the ScanSpec already. A test is also added for such case. If there are more than one equality delete field, or the field is not an Iceberg identifier field, the values would be converted to a typed expression in the conjunct of disconjunts form. This expression would be evaluated as the remaining filter function after the rows are read into the Velox vectors. Note that this only works for Presto now as the "neq" function is not registered by Spark. See https://github.com/ facebookincubator/issues/12667 Note that this commit only supports integral types. VARCHAR and VARBINARY need to be supported in future commits (see facebookincubator#12664). Co-authored-by: Naveen Kumar Mahadevuni <[email protected]> Alchemy-item: (ID = 675) Iceberg staging hub commit 2/12 - 813d750
Alchemy-item: (ID = 675) Iceberg staging hub commit 3/12 - 662374d
Alchemy-item: (ID = 675) Iceberg staging hub commit 4/12 - 1b67eb8
Co-authored-by: Chengcheng Jin <[email protected]> Alchemy-item: (ID = 675) Iceberg staging hub commit 5/12 - 0acd427
Alchemy-item: (ID = 675) Iceberg staging hub commit 6/12 - b1b6bf9
Alchemy-item: (ID = 675) Iceberg staging hub commit 7/12 - b65a48f
…finity. Alchemy-item: (ID = 675) Iceberg staging hub commit 8/12 - 4b89b2e
Alchemy-item: (ID = 675) Iceberg staging hub commit 9/12 - 87541a9
Alchemy-item: (ID = 675) Iceberg staging hub commit 10/12 - 39e063c
prestodb-ci
force-pushed
the
main
branch
19 times, most recently
from
ea5e296 to
2c6979e
Compare
prestodb-ci
force-pushed
the
main
branch
9 times, most recently
from
71a1d3c to
1b482bf
Compare
|
Closing this in favour of #1249 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.