Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor code according to upstream changes #62

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

Conversation

tdoublep
Copy link
Member

@tdoublep tdoublep commented Jan 17, 2025

This PR reworks our code according to some important upstream changes. In particular, there is no longer any need to have a separate SpyreExecutor and MultiprocessingSpyreExecutor`. Upstream has added generic classes for this that work across different platforms. Acutally, it simplifies our code quite a lot.

TODO - the embeddings stuff needs to be re-worked a bit too

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

Signed-off-by: Thomas Parnell <[email protected]>
Signed-off-by: Thomas Parnell <[email protected]>
Signed-off-by: Thomas Parnell <[email protected]>
Signed-off-by: Thomas Parnell <[email protected]>
Signed-off-by: Thomas Parnell <[email protected]>
Signed-off-by: Thomas Parnell <[email protected]>
@tdoublep tdoublep marked this pull request as ready for review January 17, 2025 20:06
Signed-off-by: Thomas Parnell <[email protected]>
@tdoublep tdoublep marked this pull request as draft January 17, 2025 20:36
@tdoublep
Copy link
Member Author

Still needs some work; moved back to draft.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant