Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Module][Playbook][1720]Playbook_zfs_resize #295

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

AndreMarcel99
Copy link
Contributor

SUMMARY

Add playbooks about cases to works with gds.

ISSUE TYPE
  • Enabler Pull Request

###############################################################################

###############################################################################
# This sample playbook demonstrates how to create a new Generation Data Group(GDG),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This description seems to be for a different playbook.

###############################################################################

###############################################################################
# This sample playbook demonstrates how to create a new Generation Data Group(GDG),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This description also looks like is from GDG.

Copy link
Contributor

@fernandofloresg fernandofloresg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving a possible grammar improvement

Copy link
Member

@rexemin rexemin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good, I just left a bunch of suggestions regarding the comments and task names in the playbooks.

# Shrink ZFS aggregate with verbose mode.
# ##########################################################################

- name: "Shrink ZFS aggregate data set {{ zfs_data_set }} on track size."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- name: "Shrink ZFS aggregate data set {{ zfs_data_set }} on track size."
- name: "Shrink zFS aggregate data set {{ zfs_data_set }} on track size."

debug:
msg: "{{ shrink_output }}"

- name: "Shrink ZFS aggregate data set {{ zfs_data_set }} and verbose mode."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- name: "Shrink ZFS aggregate data set {{ zfs_data_set }} and verbose mode."
- name: "Shrink zFS aggregate data set {{ zfs_data_set }} and enable verbose mode."

msg: "{{ shrink_output }}"

# ##########################################################################
# clean up - unmount and delete ZFS data sets
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# clean up - unmount and delete ZFS data sets
# clean up - unmount and delete zFS data sets

# clean up - unmount and delete ZFS data sets
# ##########################################################################

- name: Unmount ZFS data set.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- name: Unmount ZFS data set.
- name: Unmount zFS data set.

- name: Unmount ZFS data set.
command: "/usr/sbin/unmount {{ mount_point }}"

- name: Delete ZFS data set.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- name: Delete ZFS data set.
- name: Delete zFS data set.

AndreMarcel99 and others added 2 commits March 19, 2025 13:25
Co-authored-by: Fernando Flores <[email protected]>
@AndreMarcel99 AndreMarcel99 requested a review from rexemin March 19, 2025 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants