-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Module][Playbook][1720]Playbook_zfs_resize #295
base: main
Are you sure you want to change the base?
Conversation
############################################################################### | ||
|
||
############################################################################### | ||
# This sample playbook demonstrates how to create a new Generation Data Group(GDG), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This description seems to be for a different playbook.
zos_concepts/zfsadm/grow_zfs_fetch_full_trace_back/grow_zfs_fetch_trace_back.yml
Outdated
Show resolved
Hide resolved
############################################################################### | ||
|
||
############################################################################### | ||
# This sample playbook demonstrates how to create a new Generation Data Group(GDG), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This description also looks like is from GDG.
Co-authored-by: Fernando Flores <[email protected]>
Co-authored-by: Fernando Flores <[email protected]>
Co-authored-by: Fernando Flores <[email protected]>
…tch_trace_back.yml Co-authored-by: Fernando Flores <[email protected]>
Co-authored-by: Fernando Flores <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leaving a possible grammar improvement
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good, I just left a bunch of suggestions regarding the comments and task names in the playbooks.
zos_concepts/zfsadm/grow_zfs_fetch_full_trace_back/grow_zfs_fetch_trace_back.yml
Outdated
Show resolved
Hide resolved
zos_concepts/zfsadm/grow_zfs_fetch_full_trace_back/grow_zfs_fetch_trace_back.yml
Outdated
Show resolved
Hide resolved
zos_concepts/zfsadm/grow_zfs_fetch_full_trace_back/grow_zfs_fetch_trace_back.yml
Outdated
Show resolved
Hide resolved
zos_concepts/zfsadm/grow_zfs_fetch_full_trace_back/grow_zfs_fetch_trace_back.yml
Outdated
Show resolved
Hide resolved
# Shrink ZFS aggregate with verbose mode. | ||
# ########################################################################## | ||
|
||
- name: "Shrink ZFS aggregate data set {{ zfs_data_set }} on track size." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- name: "Shrink ZFS aggregate data set {{ zfs_data_set }} on track size." | |
- name: "Shrink zFS aggregate data set {{ zfs_data_set }} on track size." |
debug: | ||
msg: "{{ shrink_output }}" | ||
|
||
- name: "Shrink ZFS aggregate data set {{ zfs_data_set }} and verbose mode." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- name: "Shrink ZFS aggregate data set {{ zfs_data_set }} and verbose mode." | |
- name: "Shrink zFS aggregate data set {{ zfs_data_set }} and enable verbose mode." |
msg: "{{ shrink_output }}" | ||
|
||
# ########################################################################## | ||
# clean up - unmount and delete ZFS data sets |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# clean up - unmount and delete ZFS data sets | |
# clean up - unmount and delete zFS data sets |
# clean up - unmount and delete ZFS data sets | ||
# ########################################################################## | ||
|
||
- name: Unmount ZFS data set. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- name: Unmount ZFS data set. | |
- name: Unmount zFS data set. |
- name: Unmount ZFS data set. | ||
command: "/usr/sbin/unmount {{ mount_point }}" | ||
|
||
- name: Delete ZFS data set. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- name: Delete ZFS data set. | |
- name: Delete zFS data set. |
Co-authored-by: Fernando Flores <[email protected]>
Co-authored-by: Alex Moreno <[email protected]>
SUMMARY
Add playbooks about cases to works with gds.
ISSUE TYPE