Open
Conversation
Collaborator
Author
|
This format was agreed on by E3SM developers interested in using pcd.yaml. |
Collaborator
Author
|
After phone discussion with @rmontuoro : change "citation" to "reference" in entry for constant. Also make sure CPCD parser still works. Add python parser. |
rljacob
force-pushed
the
rljacob/update-yaml-format
branch
from
cb85275 to
631d76a
Compare
This was referenced Aug 22, 2025
Merged
Merged
Instead of grouping contstants by reference, define broader groups: mathematical, universal_physical, earth_physical, solar, water. This allows constants in each group to be from different references. Move all references to a section at top and then add as key in each constant.
Update build system to autoconf 2.72, aclocal 1.18.1
Update test req.yaml to refer to new format of pcd.yaml
Change citation to reference in the entries of pcd.yaml
rljacob
force-pushed
the
rljacob/update-yaml-format
branch
from
631d76a to
f8534d8
Compare
Add version and institution to output fortran file
Change URL for repo output as part of help
Update documentaiton to match changes in yaml file
Make request file argument optional. If not provided, parser will convert all the constants in the pcd.yaml file
Add .gitnore files for cpcd to ignore build artifacts
Update docs to match changes in cpcd parser
Add a python tool to generate a f90/cxx file from the pcd.yaml database
Add documentation for python parser
Collaborator
Author
|
@rmontuoro I finally added the python parser and updated the documentation. This is ready for final review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of grouping constants by reference, define broader groups: mathematical, universal_physical, earth_physical, solar, water. This allows constants in each group to possibly be from different references. It also provides a more
physically intuitive high-level grouping.
Move all references to a section at top and then add as key in each constant.
Update CPCD parser to work with new format. Also change requests argument to be optional. Update Autoconf build to GNU Autoconf 2.72.
Add Python-based parser as another tool.
Update documentation to reflect changes to yaml file and CPCD parser and new python parser.