Skip to content

fix if all smaples get selected implicitly#575

Merged
LeaSeep merged 3 commits into
developfrom
code_gen_bug_fix
Jul 2, 2026
Merged

fix if all smaples get selected implicitly#575
LeaSeep merged 3 commits into
developfrom
code_gen_bug_fix

Conversation

@LeaSeep

@LeaSeep LeaSeep commented Jul 2, 2026

Copy link
Copy Markdown
Collaborator

small bug fix in code generation if not explicitly all selected in the code generation it retruns no samples at all

@LeaSeep LeaSeep requested a review from PaulJonasJost July 2, 2026 08:53
@PaulJonasJost

Copy link
Copy Markdown
Collaborator

weird, shouldn't this case be covered in the else bracket or do I misunderstand the bug? Thanks for noticing though.

@LeaSeep

LeaSeep commented Jul 2, 2026

Copy link
Copy Markdown
Collaborator Author

No due to sample_type not necessarily holds the exact items that match the actual sample names

@LeaSeep LeaSeep merged commit 2396b63 into develop Jul 2, 2026
1 check passed
@LeaSeep LeaSeep deleted the code_gen_bug_fix branch July 2, 2026 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants