refactor(tasks): ArtifactTask reads its configuration from the task args - #2308
Open
pirhoo wants to merge 9 commits into
Open
refactor(tasks): ArtifactTask reads its configuration from the task args#2308pirhoo wants to merge 9 commits into
pirhoo wants to merge 9 commits into
Conversation
…ult instead of dropping the key
pirhoo
force-pushed
the
fix/2298-artifact-task-args
branch
from
August 10, 2026 15:47
aa1c236 to
2a80136
Compare
pirhoo
marked this pull request as ready for review
August 10, 2026 17:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2298.
ARTIFACT was the only pipeline stage reading process-wide properties instead of its task args. Moving it to task args exposed four bugs in how a
-ssettings file resolves against CLI option defaults, on both the legacy jopt parser and the picocli one, so those are fixed here too.ArtifactTaskreads its configuration from the task args instead of the injected process-widePropertiesProvider, like every other stage already doesartifactDirreaches the ARTIFACT stage instead of failing it-s, so a classpathdatashare.propertiesno longer outranks every option defaultresume=trueno longer makes-rmean "do not resume"PropertiesProvider.getFileProperties(), soDS_DOCKER_*env vars keep the precedenceCommonModegives them instead of beating an option default only when-shappens to be passedDatashareCliTest,SettingsDefaultsTestandPropertiesProviderTestNot covered
-s<path>(attached short form) is still not parsed bysettingsPathFrom, so the settings file is ignored on the picocli path for that invocation style.ArtifactTaskreads task args throughjava.util.Properties, so a non-String arg from the API or Temporal is silently dropped.DS_DOCKER_*env vars still lose to any option that declares a default, becauseCommonModelayers the CLI properties on top. That contradicts the precedence documented onSettingsResource.patchSettings, but it predates this branch and changing it would affect every Docker deployment, so it is left alone here.