-
Notifications
You must be signed in to change notification settings - Fork 314
Location factor #1642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Lingyan90
wants to merge
16
commits into
main
Choose a base branch
from
location_factor
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Location factor #1642
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
bb5558c
added location factor data bank and imported into costing_base.py
Lingyan90 8ecd844
Merge branch 'main' into location_factor
Lingyan90 818a04a
added location factor test
Lingyan90 9d733c1
sslw add location factor
Lingyan90 7698091
Update SSLW.py
Lingyan90 3957921
Update costing_base.py
Lingyan90 72a971f
Merge branch 'main' into location_factor
ksbeattie 6347886
Merge branch 'location_factor' of https://github.com/IDAES/idaes-pse …
bpaul4 cc824ab
address reviewer comments, rename test_SSLW file to naming convention
bpaul4 e76e943
add tests and related changes
bpaul4 6209357
run black
bpaul4 0e508f5
Merge branch 'main' into location_factor
bpaul4 e92a7dc
fix typo
bpaul4 b7ed334
fix import order for pylint
bpaul4 572e066
address Tomi's reviewer suggestions
bpaul4 7813709
run black again
bpaul4 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For clarification, does this imply that the benchmark for country factors, pulled from Compass International, is also Washington, D.C., USA? If not, we might be erroneously mixing factors with different benchmarks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The factors from Compass International have a benchmark of 1.0 for Washington, D.C., USA and everything else is in relation to that. The regional US factors from Seider were scaled so that Northeast (which is assumed to be the same region as DC) is 1.0.