Skip to content

Conversation

@dangunter
Copy link
Member

@dangunter dangunter commented Nov 13, 2025

Fixes #1701

Summary/Motivation:

Need additional flowsheet structure to incorporate into Jupyter UI plans

Changes proposed in this PR:

  • utility code to wrap a flowsheet, in runner and fsrunner modules
  • log utility for removing spurious output (useful for UIs), in logutil
  • action for timing, in runner_actions module
  • example wrapped flowsheet (IDAES modules only)
  • tests to desired coverage level
  • documentation

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@dangunter dangunter self-assigned this Nov 13, 2025
@dangunter dangunter marked this pull request as draft November 13, 2025 14:47
@dangunter dangunter added the enhancement New feature or request label Nov 13, 2025
@ksbeattie ksbeattie added the Priority:Normal Normal Priority Issue or PR label Nov 13, 2025
@codecov
Copy link

codecov bot commented Nov 17, 2025

Codecov Report

❌ Patch coverage is 92.38411% with 23 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.50%. Comparing base (36e6eb8) to head (5aa7b0e).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
idaes/core/util/structfs/runner_actions.py 86.66% 7 Missing and 9 partials ⚠️
idaes/core/util/structfs/runner.py 94.44% 4 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1702      +/-   ##
==========================================
+ Coverage   77.46%   77.50%   +0.03%     
==========================================
  Files         395      399       +4     
  Lines       64763    65094     +331     
  Branches    10897    10947      +50     
==========================================
+ Hits        50171    50452     +281     
- Misses      12084    12116      +32     
- Partials     2508     2526      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dangunter dangunter requested a review from CopyDemon December 19, 2025 00:16
@dangunter
Copy link
Member Author

@CopyDemon added you as a reviewer. Still very much a WIP!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Priority:Normal Normal Priority Issue or PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flowsheet building/running/introspection for Jupyter integration

2 participants