Skip to content

Conversation

@Xinhe-Chen
Copy link
Contributor

@Xinhe-Chen Xinhe-Chen commented Dec 2, 2025

Fixes

This PR adds new features to the price-taker class.

Summary/Motivation:

The unit commitment model in the current price-taker class only supports a single type of startup. However, some generators have different startup types (e.g., hot and cold start) because their physical components heat up and cool down over time, so the time since last shutdown affects how much fuel it costs, and how much wear-and-tear is incurred to bring them back online.

The startup model is based on Knueven, Bernard, James Ostrowski, and Jean-Paul Watson. "On mixed-integer programming formulations for the unit commitment problem." INFORMS Journal on Computing 32, no. 4 (2020): 857-876.

Changes proposed in this PR:

  • Add the method for supporting the various startup types for the idaes price-taker class.
  • Add tests for the method.

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@codecov
Copy link

codecov bot commented Dec 2, 2025

Codecov Report

❌ Patch coverage is 92.85714% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.63%. Comparing base (c8c3df6) to head (38947cc).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...s/grid_integration/pricetaker/price_taker_model.py 50.00% 1 Missing ⚠️
...pps/grid_integration/pricetaker/unit_commitment.py 95.65% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1713      +/-   ##
==========================================
- Coverage   77.36%   73.63%   -3.74%     
==========================================
  Files         394      394              
  Lines       64980    65006      +26     
  Branches    10947    10954       +7     
==========================================
- Hits        50274    47867    -2407     
- Misses      12197    14632    +2435     
+ Partials     2509     2507       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sufikaur sufikaur added the Priority:Normal Normal Priority Issue or PR label Dec 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Priority:Normal Normal Priority Issue or PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants