-
Notifications
You must be signed in to change notification settings - Fork 283
Add Various Startup Types Support to the Price-taker Class #1713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Xinhe-Chen
wants to merge
16
commits into
IDAES:main
Choose a base branch
from
Xinhe-Chen:various_startup
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1713 +/- ##
==========================================
- Coverage 77.36% 73.63% -3.74%
==========================================
Files 394 394
Lines 64980 65006 +26
Branches 10947 10954 +7
==========================================
- Hits 50274 47867 -2407
- Misses 12197 14632 +2435
+ Partials 2509 2507 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ruonanli61
requested changes
Dec 16, 2025
ruonanli61
approved these changes
Dec 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
This PR adds new features to the price-taker class.
Summary/Motivation:
The unit commitment model in the current price-taker class only supports a single type of startup. However, some generators have different startup types (e.g., hot and cold start) because their physical components heat up and cool down over time, so the time since last shutdown affects how much fuel it costs, and how much wear-and-tear is incurred to bring them back online.
The startup model is based on Knueven, Bernard, James Ostrowski, and Jean-Paul Watson. "On mixed-integer programming formulations for the unit commitment problem." INFORMS Journal on Computing 32, no. 4 (2020): 857-876.
Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: